Skip to content

test: enable float/double/binary array casts to string #4386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
manuzhang wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

test: enable float/double/binary array casts to string #4386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions spark/src/main/scala/org/apache/comet/expressions/CometCast.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,6 @@ object CometCast extends CometExpressionSerde[Cast] with CometExprShim {
case (ArrayType(DataTypes.DateType, _), ArrayType(toElementType, _))
if toElementType != DataTypes.IntegerType && toElementType != DataTypes.StringType =>
unsupported(fromType, toType)
case (dt: ArrayType, DataTypes.StringType) if dt.elementType == DataTypes.BinaryType =>
Incompatible()
case (dt: ArrayType, DataTypes.StringType) =>
isSupported(dt.elementType, DataTypes.StringType, timeZoneId, evalMode)
case (dt: ArrayType, dt1: ArrayType) =>
Expand Down
6 changes: 3 additions & 3 deletions spark/src/test/scala/org/apache/comet/CometCastSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1555,9 +1555,9 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper {
IntegerType,
LongType,
ShortType,
// FloatType,
// DoubleType,
// BinaryType
FloatType,
DoubleType,
BinaryType,
DecimalType(10, 2),
DecimalType(38, 18)).foreach { dt =>
val input = generateArrays(100, dt)
Expand Down
Loading