docs: Update Parquet scan documentation#3433
Open
andygrove wants to merge 14 commits intoapache:mainfrom
Open
Conversation
Fix grammar, add encryption fallback and native_iceberg_compat hard-coded config limitations, clarify S3 section applies to both scan implementations, and remove orphaned link references. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Clarify which limitations fall back to Spark vs which may produce incorrect results. Add missing documented limitations for native_datafusion (DPP, input_file_name, metadata columns). Fix misleading wording for ignoreCorruptFiles/ignoreMissingFiles. Note that auto mode currently always selects native_iceberg_compat. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The section intro already states all limitations fall back to Spark, so individual bullet points don't need to repeat it. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Restructure shared and per-scan limitation lists into two clear categories: features that fall back to Spark (safe) and issues that may produce incorrect results without falling back. Remove redundant "Comet falls back to Spark" from individual bullets where the section intro already states it. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR removes all references to the deprecated
native_cometscan implementation from the documentation andconfiguration, and improves the accuracy and clarity of the Parquet scan documentation.
Changed Files
common/src/main/scala/org/apache/comet/CometConf.scalaspark.comet.scan.implfromCATEGORY_SCANtoCATEGORY_PARQUETnative_datafusionandnative_iceberg_compatwithout referencingnative_comet.internal()marker, making this configuration visible to usersdocs/source/contributor-guide/parquet_scans.mdMajor rewrite of the Parquet scan documentation:
native_cometscan (previously listed as one of three implementations)native_cometand the "benefits over native_comet" sectionnative_cometS3 section (which described Hadoop-AWS-based S3 access)native_datafusionandnative_iceberg_compat(previously only referenced
native_datafusion)automode currently always selectsnative_iceberg_compatresults with reduced performance
for both scans, hard-coded config defaults for
native_iceberg_compat)native_datafusionlimitations that cause fallback:input_file_name(),input_file_block_start(),input_file_block_length()SQL functions_metadata.file_path)ignoreMissingFiles/ignoreCorruptFiles(previously said "not compatible with Spark",now clarifies it falls back to Spark)
#1545,#1758) that referenced oldnative_datafusionissuesdocs/source/contributor-guide/ffi.mdnative_cometwith a general description of scans that use mutable buffersdocs/source/contributor-guide/roadmap.mdnative_comettonative_iceberg_compattransition