-
Notifications
You must be signed in to change notification settings - Fork 247
Chore: refactor bit_count #2553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The DataFusion implementation produces results that are not compatible with Spark Project [bit_count(col2#2190) AS bit_count(col2)#2218] == Physical Plan == == Results == == Results == |
|
Triggering CI |
|
there is still a conflict 🤔 |
# Conflicts: # spark/src/main/scala/org/apache/comet/serde/bitwise.scala
|
Thanks @comphead, conflicts resolved. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2553 +/- ##
=============================================
- Coverage 56.12% 45.97% -10.16%
- Complexity 976 1200 +224
=============================================
Files 119 146 +27
Lines 11743 13746 +2003
Branches 2251 2354 +103
=============================================
- Hits 6591 6320 -271
- Misses 4012 6385 +2373
+ Partials 1140 1041 -99 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
*** 3 TESTS FAILED *** |
I think the DataFusion implementation needs modification to be fully compatible with Spark. |
Which issue does this PR close?
Part of: #2443
Rationale for this change
Part of: #2443
What changes are included in this PR?
How are these changes tested?
Tested with existing unit tests