Skip to content

Conversation

@kazantsev-maksim
Copy link
Contributor

Which issue does this PR close?

Part of: #2443

Rationale for this change

Part of: #2443

What changes are included in this PR?

How are these changes tested?

Tested with existing unit tests

@kazantsev-maksim
Copy link
Contributor Author

kazantsev-maksim commented Oct 12, 2025

The DataFusion implementation produces results that are not compatible with Spark

Project [bit_count(col2#2190) AS bit_count(col2)#2218]
+- Relation spark_catalog.default.bitwise_count_test[col1#2189L,col2#2190,col3#2191,col4#2192] parquet

== Physical Plan ==
*(1) CometColumnarToRow
+- CometProject [bit_count(col2)#2218], [bit_count(col2#2190) AS bit_count(col2)#2218]
+- CometScan [native_iceberg_compat] parquet spark_catalog.default.bitwise_count_test[col2#2190] Batched: true, DataFilters: [], Format: CometParquet, Location: InMemoryFileIndex(1 paths)[file:/Users/tendoo/Desktop/datafusion-comet/spark/spark-warehouse/bitw..., PartitionFilters: [], PushedFilters: [], ReadSchema: structcol2:int

== Results ==

== Results ==
!== Correct Answer - 3 == == Spark Answer - 3 ==
struct<bit_count(col2):int> struct<bit_count(col2):int>
![31] [1]
![33] [31]
[6] [6] (QueryTest.scala:244)

@andygrove @comphead

@comphead
Copy link
Contributor

Triggering CI

@comphead
Copy link
Contributor

there is still a conflict 🤔

Kazantsev Maksim added 2 commits October 20, 2025 20:44
# Conflicts:
#	spark/src/main/scala/org/apache/comet/serde/bitwise.scala
@kazantsev-maksim
Copy link
Contributor Author

kazantsev-maksim commented Oct 20, 2025

Thanks @comphead, conflicts resolved.

@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.97%. Comparing base (f09f8af) to head (f03f59d).
⚠️ Report is 624 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #2553       +/-   ##
=============================================
- Coverage     56.12%   45.97%   -10.16%     
- Complexity      976     1200      +224     
=============================================
  Files           119      146       +27     
  Lines         11743    13746     +2003     
  Branches       2251     2354      +103     
=============================================
- Hits           6591     6320      -271     
- Misses         4012     6385     +2373     
+ Partials       1140     1041       -99     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@comphead
Copy link
Contributor

*** 3 TESTS FAILED ***

@kazantsev-maksim
Copy link
Contributor Author

*** 3 TESTS FAILED ***

I think the DataFusion implementation needs modification to be fully compatible with Spark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants