-
Notifications
You must be signed in to change notification settings - Fork 247
feat: Iceberg scan based serializing FileScanTasks to iceberg-rust #2528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2528 +/- ##
============================================
- Coverage 56.12% 55.14% -0.99%
- Complexity 976 1386 +410
============================================
Files 119 148 +29
Lines 11743 14348 +2605
Branches 2251 2474 +223
============================================
+ Hits 6591 7912 +1321
- Misses 4012 5218 +1206
- Partials 1140 1218 +78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
It is promising! |
227332c to
6966a12
Compare
# Conflicts: # native/Cargo.lock # spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala
…eberg version back to 1.8.1 after hitting known segfaults with old versions.
## Which issue does this PR close? - Part of #1749. ## What changes are included in this PR? - Change `ArrowReaderBuilder::new` to be `pub` instead of `pub(crate)`. ## Are these changes tested? - No new tests for this. Currently being used in DataFusion Comet: apache/datafusion-comet#2528
# Conflicts: # docs/source/user-guide/latest/configs.md # native/Cargo.lock # native/Cargo.toml # native/core/Cargo.toml
# Conflicts: # native/Cargo.lock # native/core/Cargo.toml
|
I had to turn off
|
…rtition pruning works okay. This fixes TestPartitionPruning Iceberg Java tests.
…ssions with complex types.




This is mostly for discussion at the moment. There are slides from the 10/9/25 Iceberg-Rust community call here where I presented this effort here.
Rationale for this change
I was inspired by @RussellSpitzer's recent talk and wanted to revisit the abstraction layer at which Comet integrates with Iceberg. We have the
iceberg_compatcodepath for Iceberg integration, but this requires code changes in Iceberg Java to integrate with Parquet reader instantiation. Instead, this prototype works at theFileScanTasklayer after planning. This prototype starts us toward fully-native Iceberg scans to match our Parquet logic withnative_datafusionscans without any changes in upstream Iceberg Java code.What changes are included in this PR?
CometIcebergNativeScanExecnode on the Scala side.FileScanTasks and serialize to native code.IcebergScanExecon native side that usesFileScanTasks to perform reads iniceberg-rust.How are these changes tested?
New
CometIcebergNativeSuite.Benefits over
iceberg_compat?native_datafusion.iceberg_compat).iceberg-rust. I think I already found a shortcoming with row group pruning logic.Current Limitations/Concerns?
iceberg-rustand will open a PR there to make an API public. Currently this PR relies on my fork oficeberg-rust.iceberg_compatto Iceberg.iceberg-rustin sync with Comet's DataFusion dependency. I also had to bump myiceberg-rustfork to DataFusion 50.RecordBatchTransformerinstead ofSchemaAdapter/PhysicalExprAdapter. Need to understand the compatibility gap there.ArrowReaderOptionsyet (needed for proper Spark-compatible INT96 handling) https://github.com/apache/iceberg-rust/blob/dc349284a4204c1a56af47fb3177ace6f9e899a0/crates/iceberg/src/arrow/reader.rs#L1384.