-
Notifications
You must be signed in to change notification settings - Fork 246
feat:Support ANSI mode integral divide #2421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2421 +/- ##
============================================
+ Coverage 56.12% 58.91% +2.79%
- Complexity 976 1457 +481
============================================
Files 119 147 +28
Lines 11743 13644 +1901
Branches 2251 2369 +118
============================================
+ Hits 6591 8039 +1448
- Misses 4012 4381 +369
- Partials 1140 1224 +84 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This will be rebased with main once #2136 is merged to main |
8cebd01
to
065a822
Compare
Rebased with main since #2136 is merged . @andygrove |
@andygrove please take a look whenever you get a chance . (The failed tests are due to a transient issue) |
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala
Outdated
Show resolved
Hide resolved
ae9bbd7
to
beb8cf6
Compare
@andygrove I implemented the changes per review comments . Please take a look whenever you get a chance |
Fixed scala format / style issues |
@andygrove , barring 2 failed tests due to transient network / pod issues, all other tests seems to be passing . Please review whenever you get a chance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @coderfender
@andygrove all tests passed . Please merge the festive branch at your convenience |
Thank you |
Which issue does this PR close?
Closes #533
Rationale for this change
What changes are included in this PR?
How are these changes tested?