Skip to content

Conversation

coderfender
Copy link
Contributor

@coderfender coderfender commented Sep 19, 2025

Which issue does this PR close?

Closes #533

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@coderfender coderfender changed the title Support integral divide feat:Support ANSI mode integral divide Sep 19, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 58.91%. Comparing base (f09f8af) to head (57ef659).
⚠️ Report is 583 commits behind head on main.

Files with missing lines Patch % Lines
...main/scala/org/apache/comet/serde/arithmetic.scala 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2421      +/-   ##
============================================
+ Coverage     56.12%   58.91%   +2.79%     
- Complexity      976     1457     +481     
============================================
  Files           119      147      +28     
  Lines         11743    13644    +1901     
  Branches       2251     2369     +118     
============================================
+ Hits           6591     8039    +1448     
- Misses         4012     4381     +369     
- Partials       1140     1224      +84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coderfender
Copy link
Contributor Author

This will be rebased with main once #2136 is merged to main

@coderfender coderfender force-pushed the support_integral_divide branch from 8cebd01 to 065a822 Compare September 25, 2025 22:49
@coderfender coderfender marked this pull request as ready for review September 25, 2025 22:50
@coderfender
Copy link
Contributor Author

Rebased with main since #2136 is merged . @andygrove

@coderfender
Copy link
Contributor Author

@andygrove please take a look whenever you get a chance . (The failed tests are due to a transient issue)

@coderfender coderfender force-pushed the support_integral_divide branch from ae9bbd7 to beb8cf6 Compare October 10, 2025 02:21
@coderfender
Copy link
Contributor Author

@andygrove I implemented the changes per review comments . Please take a look whenever you get a chance

@coderfender
Copy link
Contributor Author

Fixed scala format / style issues

@coderfender
Copy link
Contributor Author

@andygrove , barring 2 failed tests due to transient network / pod issues, all other tests seems to be passing . Please review whenever you get a chance

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @coderfender

@coderfender
Copy link
Contributor Author

@andygrove all tests passed . Please merge the festive branch at your convenience

@andygrove andygrove merged commit 0ddd89f into apache:main Oct 10, 2025
175 of 177 checks passed
@coderfender
Copy link
Contributor Author

Thank you

@coderfender coderfender deleted the support_integral_divide branch October 10, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ANSI support for Divide and IntegralDivide

3 participants