Evaluate assert/discriminator expressions after groupContent: WIP #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to 9.5 of the DFDL spec assert and discriminators with expressions should be processed after the content of their enclosing sequence, group, or choice. Before these expressions were always being processed before the content. This commit also moves the setVariable expression evaluaiton to the correct place, which is before the enclosing group. DAFFODIL-1971, DAFFODIL-1590
|
This is primarily WIP as it needs more test coverage and I have been informed that I need to hold off on working on this for a little while. It is fully functional, just needs more tests for edge cases surrounding evaluating expressions after the content of sequences, groups, and choices. Also need to add tests for the setVariable change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to 9.5 of the DFDL spec assert and discriminators with expressions should be processed after the content of their enclosing sequence, group, or choice. Before these expressions were always being processed before the content.
This commit also moves the setVariable expression evaluaiton to the correct place, which is before the enclosing group.
DAFFODIL-1971, DAFFODIL-1590