Fix short names in CLI debugger #1476
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes all remaining uses of the name parameter when doing things like filtering or searching subcommands. Instead, we now always uses the "matches" function, which takes into account both short and long name. This fixes the "info" command and the "diffExcludes" setting. The name variable is now only used when when outputting the name of a debugger command that was run. This also always enables debugger command name conflict detection. It doesn't really need to always be run, but we never uncomment this to actually check for conflicts, and it's fast enough that it's not noticable. DAFFODIL-2991
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all remaining uses of the name parameter when doing things like filtering or searching subcommands. Instead, we now always uses the "matches" function, which takes into account both short and long name. This fixes the "info" command and the "diffExcludes" setting.
The name variable is now only used when when outputting the name of a debugger command that was run.
This also always enables debugger command name conflict detection. It doesn't really need to always be run, but we never uncomment this to actually check for conflicts, and it's fast enough that it's not noticable.
DAFFODIL-2991