Skip to content

Include the cause when a plugin fails to be instantiated #1471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevedlawrence merged 1 commit into from
May 2, 2025
Merged

Include the cause when a plugin fails to be instantiated #1471

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions daffodil-lib/src/main/scala/org/apache/daffodil/lib/util/SimpleNamedServiceLoader.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
*/
package org.apache.daffodil.lib.util

import java.io.PrintWriter
import java.io.StringWriter
import java.util.ServiceConfigurationError
import java.util.ServiceLoader
import scala.collection.mutable.ArrayBuffer
Expand Down Expand Up @@ -49,8 +51,18 @@ object SimpleNamedServiceLoader {
try {
instanceBuf += iter.next()
} catch {
case e: ServiceConfigurationError =>
Logger.log.warn(s"Named service $thingName failed to load. Cause: ${e.getMessage}")
case e: ServiceConfigurationError => {
Logger.log.warn(
s"Named service $thingName failed to load: ${e.getMessage}. Enable debug logging for more details"
)
Logger.log.debug({
val sw = new StringWriter()
val pw = new PrintWriter(sw, true)
e.printStackTrace(pw)
pw.close()
sw.toString()
})
}
}
}
val instancesFound: Map[String, Seq[T]] = instanceBuf.toSeq.groupBy { _.name() }
Expand Down
13 changes: 12 additions & 1 deletion ...runtime1/src/main/scala/org/apache/daffodil/runtime1/udf/UserDefinedFunctionService.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,9 @@ import java.io.ByteArrayOutputStream
import java.io.NotSerializableException
import java.io.ObjectInputStream
import java.io.ObjectOutputStream
import java.io.PrintWriter
import java.io.Serializable
import java.io.StringWriter
import java.lang.reflect.Method
import java.util.ServiceConfigurationError
import java.util.ServiceLoader
Expand Down Expand Up @@ -110,7 +112,16 @@ object UserDefinedFunctionService {
Some(providerIter.next())
} catch {
case e: ServiceConfigurationError => {
Logger.log.warn(s"User Defined Function Provider failed to load: ${e.getMessage}")
Logger.log.warn(
s"User Defined Function Provider failed to load: ${e.getMessage}. Enable debug logging for more details"
)
Logger.log.debug({
val sw = new StringWriter()
val pw = new PrintWriter(sw)
e.printStackTrace(pw)
pw.close()
sw.toString()
})
None
}
}
Expand Down
5 changes: 4 additions & 1 deletion daffodil-test-integration/src/test/scala/org/apache/daffodil/cliTest/TestCLIUdfs.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,13 +369,16 @@ class TestCLIUdfs {
"daffodil-udf/src/test/scala/org/sbadudfs/udfpexceptions2/StringFunctions/"
)

runCLI(args"-v parse -s $schema -r user_func3", classpath) { cli =>
runCLI(args"-vv parse -s $schema -r user_func3", classpath) { cli =>
cli.expectErr(
"[warn] User Defined Function Provider failed to load: org.apache.daffodil.udf.UserDefinedFunctionProvider"
)
cli.expectErr(
"Provider org.sbadudfs.udfpexceptions2.StringFunctions.StringFunctionsProvider could not be instantiated"
)
cli.expectErr(
"Caused by: org.sbadudfs.udfpexceptions2.StringFunctions.StringFunctionsProvider$CustomException: UDFP Error!"
)
cli.expectErr("[error] Schema Definition Error: Unsupported function: ssudf:rev-words")
}(ExitCode.UnableToCreateProcessor)
}
Expand Down