Skip to content

Fix warning about MultipleChildElementsWithSameName for hidden Elements #1415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix warning about MultipleChildElementsWithSameName for hidden Elements #1415

wants to merge 1 commit into from

Conversation

olabusayoT
Copy link
Contributor

  • currently we only check if the groupMember is a groupRef and the check is not recursive. With this PR we check if the current model group is a hidden group ref or sequence, we check if it's group members are hidden group refs or sequence, we check if the parents of group member elements are hidden group refs or sequences, and it's all recursive if the group member isn't an element

DAFFODIL-2968

@olabusayoT
Fix warning about MultipleChildElementsWithSameName for hidden Elements
704684d 
- currently we only check if the groupMember is a groupRef and the check is not recursive. With this PR we check if the current model group is a hidden group ref or sequence, we check if it's group members are hidden group refs or sequence, we check if the parents of group member elements are hidden group refs or sequences, and it's all recursive if the group member isn't an element

DAFFODIL-2968
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevedlawrence stevedlawrence Awaiting requested review from stevedlawrence

@jadams-tresys jadams-tresys Awaiting requested review from jadams-tresys

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@olabusayoT