Minor fixes to the release candidate container script #1280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add additional changes to commit a13501a to improve the release candidate container. - Appends a colon and space to the prompt in the get_non_empty_input function instead of in caller parameters. The callers did already add a colon but not a space so the input looked off. This ensures the colon and space always exist and callers do not have to think about it - The "Apache Password" prompt does not provide the "-s" option to hide the password. This modifies get_non_empty_input so that any parameters after the prompt are passed directly to "read" and the "Apache Password" call is modified to pass in "-s" DAFFODIL-2914
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional changes to commit a13501a to improve the release candidate container.
DAFFODIL-2914