Implement Trace functionality for CLI TDML test #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-mcgann
approved these changes
Jul 12, 2023
olabusayoT
force-pushed
the
daf-2694-cli-test-trace
branch
from
e741032
to
8d10275
Compare
mbeckerle
approved these changes
Jul 12, 2023
| Assert.usage(dp ne null) | ||
| val d = dp.asInstanceOf[Debugger] | ||
| Assert.usage(db ne null) | ||
| val d = db.asInstanceOf[Debugger] |
There was a problem hiding this comment.
Wow. What a bug.
We should disallow use of tiny value names like dp and db and spell things out a little more I think.
db here is a parameter name. That one should definitely be spelled out as 'debugger'.
There was a problem hiding this comment.
Note that code cov says this wasn't a bug, because it's not called.
There was a problem hiding this comment.
Right, I noticed the bug while working on getting the -d functionality to work with "test", it gets called then. This changeset doesn't have that functionality work, but it felt wrong to leave the bug
daffodil-cli/src/test/scala/org/apache/daffodil/cli/cliTest/TestCLItdml.scala
Show resolved
Hide resolved
|
I was able to fix the debug functionality and added a cli test to confirm it is working |
olabusayoT
force-pushed
the
daf-2694-cli-test-trace
branch
3 times, most recently
from
a8e89c0
to
15c46c6
Compare
mike-mcgann
approved these changes
Jul 12, 2023
- fix bug with debugger where we were casting the data processor as an instance of the Debugger instead of the passed in debugger - fix DAFFODIL-2833 by using TraceDebuggerRunner instead of TDMLRunner.trace - set areDebuggingFlag when a debugger is set with withDebugger - add debug.txt to rat excludes DAFFODIL-2694 DAFFODIL-2833
olabusayoT
force-pushed
the
daf-2694-cli-test-trace
branch
from
15c46c6
to
aa0995d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, we were unable to test the trace output using CLI tests as the trace output wasn't able to be found using CLI.expect. My guess is it has something to do with output being sent to a PipedOutputStream, which may be different from System.out of the other output.
DAFFODIL-2694