Specify a locale in units tests #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some unit tests do not specify a locale when creating certain objects, which causes the default system locale to be used. This can cause these tests to fail if run on a system with a different locale. This modifies those tests to specify a locale and ignore the system locale. This also modifies the GitHub actions so some jobs are run with non-US locales so that we can detect if new tests are added with locale dependent behaviors. Note that commit 1a0954a modified integration tests to not be locale dependent--only a small number of unit tests need fixing. DAFFODIL-2599, DAFFODIL-2612
mike-mcgann
approved these changes
Jun 28, 2023
tuxji
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some unit tests do not specify a locale when creating certain objects, which causes the default system locale to be used. This can cause these tests to fail if run on a system with a different locale. This modifies those tests to specify a locale and ignore the system locale.
This also modifies the GitHub actions so some jobs are run with non-US locales so that we can detect if new tests are added with locale dependent behaviors.
Note that commit 1a0954a modified integration tests to not be locale dependent--only a small number of unit tests need fixing.
DAFFODIL-2599, DAFFODIL-2612