Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CURATOR-717: Fix typo in CuratorCache Javadoc #507

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

pdolif
Copy link
Contributor

@pdolif pdolif commented Sep 29, 2024

There is a typo in the CuratorCache Javadoc:

Image another client that isn't partitioned, deletes "/foo/bar" and then a third client re-creates "/foo/bar"

"Image" should be "Imagine".

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! LGTM.

@tisonkun tisonkun requested a review from kezhuw October 8, 2024 15:52
@kezhuw
Copy link
Member

kezhuw commented Oct 16, 2024

I am not a native english speaker. But https://www.dictionary.com/browse/image#american-image-verb-used-with-object says that they are interchange in case of "verb".

verb (used with object), im·aged, im·ag·ing. to picture or represent in the mind; imagine; conceive.

I do search it.

Both say "image" as a verb. is rare. So I think "imagine" is good to go.

@kezhuw kezhuw merged commit 6a27ff0 into apache:master Oct 18, 2024
10 checks passed
@kezhuw
Copy link
Member

kezhuw commented Oct 18, 2024

@pdolif Thank you! Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants