Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAT-384: write xsd (RAT-384 part 2) (Harmonize - Part 5) #301

Merged
merged 62 commits into from
Sep 22, 2024

Conversation

Claudenw
Copy link
Contributor

@Claudenw Claudenw commented Aug 5, 2024

Creates an XSD for configuration files to verify configuration structure.
Updates documentation for Maven plugin.

@@ -183,7 +177,7 @@ cd creadur-rat
mvn clean install
+------------------------------------------+

or with the included Maven wrapper
or with the included Maven wrapper
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is already fixed in master ....

@ottlinger
Copy link
Contributor

@Claudenw WDYT - should we add a changelog entry for this one as it enhances the functionality and introduces the whole XSD/configuration handling?

@Claudenw
Copy link
Contributor Author

Claudenw commented Sep 17, 2024

This change has exhibited a weird error. It seem like it is pulling in commons-cli 1.9.0 while everything in the codebase seems to point to commons-cli 1.8.0

To make it even stranger, it compiles on my system even after I delete commons-cli from my local repository and make it download the jar again.

@Claudenw
Copy link
Contributor Author

@ottlinger if you approve of this we can merge it now.

The CLI update will have to wait for commons-cli 1.10.0

@ottlinger
Copy link
Contributor

@Claudenw did you push all changes? The current version only uses v1.8.0:

➜  creadur-rat git:(RAT-384_write_XSD) ./mvnw dependency:tree
.....
[INFO] 
[INFO] ------------------< org.apache.rat:apache-rat-tools >-------------------
[INFO] Building Apache Creadur Rat::Tools 0.17-SNAPSHOT                   [3/6]
[INFO]   from apache-rat-tools/pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- dependency:3.8.0:tree (default-cli) @ apache-rat-tools ---
[INFO] org.apache.rat:apache-rat-tools:jar:0.17-SNAPSHOT
[INFO] +- org.apache.rat:apache-rat-core:jar:0.17-SNAPSHOT:compile
[INFO] |  +- org.apache.commons:commons-collections4:jar:4.4:compile
[INFO] |  +- org.apache.commons:commons-lang3:jar:3.17.0:compile
[INFO] |  +- commons-io:commons-io:jar:2.16.1:compile
[INFO] |  +- org.apache.commons:commons-text:jar:1.12.0:compile
[INFO] |  +- org.junit.jupiter:junit-jupiter-api:jar:5.11.0:compile
[INFO] |  |  +- org.opentest4j:opentest4j:jar:1.3.0:compile
[INFO] |  |  +- org.junit.platform:junit-platform-commons:jar:1.11.0:compile
[INFO] |  |  \- org.apiguardian:apiguardian-api:jar:1.1.2:compile
[INFO] |  +- org.junit.vintage:junit-vintage-engine:jar:5.11.0:compile
[INFO] |  |  +- org.junit.platform:junit-platform-engine:jar:1.11.0:compile
[INFO] |  |  \- junit:junit:jar:4.13.2:compile
[INFO] |  |     \- org.hamcrest:hamcrest-core:jar:1.3:compile
[INFO] |  +- org.junit.jupiter:junit-jupiter-params:jar:5.11.0:compile
[INFO] |  \- org.apache.tika:tika-core:jar:2.9.2:compile
[INFO] |     \- org.slf4j:slf4j-api:jar:2.0.10:compile
[INFO] +- org.apache.rat:apache-rat-core:test-jar:tests:0.17-SNAPSHOT:test
[INFO] +- commons-cli:commons-cli:jar:1.8.0:compile
[INFO] +- org.apache.commons:commons-csv:jar:1.11.0:compile
[INFO] |  \- commons-codec:commons-codec:jar:1.16.1:compile
[INFO] \- org.apache.commons:commons-compress:jar:1.27.1:compile
[INFO] 

@Claudenw
Copy link
Contributor Author

@ottlinger

Yes, the current version uses commons-cli 1.8.0, v1.9.0 changes the help generation in ways that broke our output. CLI v1.10.0 should fix it but I am still working on it. I was hoping to get a first cut done this weekend but that it not looking good right now.

@@ -99,10 +99,6 @@ Apache Rat&#8482;
There are three user interfaces for Rat: from the command line, from Ant, and from Maven. All three of the interfaces
support standard options as noted in the list below.

+------------------------------------------+

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Claudenw is there an inclusion of a txt file missing here?

@ottlinger
Copy link
Contributor

@Claudenw if you are fine with my changes feel free to merge and go ahead.

Copy link
Contributor

@ottlinger ottlinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor question concerning the inclusion of a txt file and trivial changes in files.

@Claudenw Claudenw merged commit 9d1d699 into apache:master Sep 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants