-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RAT-384: write xsd (RAT-384 part 2) (Harmonize - Part 5) #301
Conversation
dcb1ddc
to
8777b82
Compare
apache-rat-core/src/main/java/org/apache/rat/report/xml/writer/impl/base/XmlWriter.java
Show resolved
Hide resolved
apache-rat-tools/src/main/java/org/apache/rat/tools/xsd/XsdWriter.java
Outdated
Show resolved
Hide resolved
apache-rat-tools/src/test/java/org/apache/rat/tools/NamingTest.java
Outdated
Show resolved
Hide resolved
src/site/apt/index.apt.vm
Outdated
@@ -183,7 +177,7 @@ cd creadur-rat | |||
mvn clean install | |||
+------------------------------------------+ | |||
|
|||
or with the included Maven wrapper | |||
or with the included Maven wrapper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is already fixed in master ....
@Claudenw WDYT - should we add a changelog entry for this one as it enhances the functionality and introduces the whole XSD/configuration handling? |
This change has exhibited a weird error. It seem like it is pulling in commons-cli 1.9.0 while everything in the codebase seems to point to commons-cli 1.8.0 To make it even stranger, it compiles on my system even after I delete commons-cli from my local repository and make it download the jar again. |
bc32a69
to
7e256b4
Compare
@ottlinger if you approve of this we can merge it now. The CLI update will have to wait for commons-cli 1.10.0 |
@Claudenw did you push all changes? The current version only uses v1.8.0:
|
Yes, the current version uses commons-cli 1.8.0, v1.9.0 changes the help generation in ways that broke our output. CLI v1.10.0 should fix it but I am still working on it. I was hoping to get a first cut done this weekend but that it not looking good right now. |
@@ -99,10 +99,6 @@ Apache Rat™ | |||
There are three user interfaces for Rat: from the command line, from Ant, and from Maven. All three of the interfaces | |||
support standard options as noted in the list below. | |||
|
|||
+------------------------------------------+ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Claudenw is there an inclusion of a txt file missing here?
@Claudenw if you are fine with my changes feel free to merge and go ahead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor question concerning the inclusion of a txt file and trivial changes in files.
Creates an XSD for configuration files to verify configuration structure.
Updates documentation for Maven plugin.