Extend remsh to read cookie from various sources
#5539
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can set cookies using `./dev/run --erlang-cookie=crumbles` or `vm.args`: `-setcookie crumbles`. If neither of them is set or we set the cookie in both places, then the Erlang node will read the cookie from `~/.erlang.cookie`. Add this mechanism to the `remsh` script to extend flexibility. Related PR: #5531
big-r81
reviewed
May 16, 2025
| erl -name "$NAME" -remsh "$NODE" -hidden | ||
| fi | ||
|
|
||
| erl -name "$NAME" -remsh "$NODE" -hidden |
There was a problem hiding this comment.
Is this necessary? We have it in the "else" branch already?
There was a problem hiding this comment.
Oops, that line should be removed. Thank you for the review.
Gábor thought the script is too complicated and adding an environment variable would be enough.
Probably I'll repurpose this PR to combine remsh and remsh-tls once I figured out why it fails in OTP 26.
|
Thanks for looking into it, but wouldn't it be better to maintain only one remsh` script, which can be used for 'dev' and 'prod'? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We can set cookies using
./dev/run --erlang-cookie=crumblesorvm.args:-setcookie crumbles.If neither of them is set or we set the cookie in both places, then the Erlang node will read the cookie from
~/.erlang.cookie.Add this mechanism to the
remshscript to extend flexibility.Related PR: #5531
Testing recommendations
Related Issues or Pull Requests
Checklist
rel/overlay/etc/default.inisrc/docsfolder