CB-13774: repair broken recording and playback functionality on Android #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert back to plugins original use of DEFAULT as the audio encode and decoder.
This reverts commit 8775450.
CB-13774: (android) Fix bug with media encoding/decoding
janpio
changed the title
|
Hey, I just fixed the problem that caused Android tests to fail in |
|
Closing and re-opening to trigger a new CI/test run with new PR merge. |
|
I had the same problem, could not record and playback on Nexus 7, Android 4.4.4. It did work with version 2.4.1. Current version 5.0.2 works on The proposed PR does not break any of the above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert back to plugins original use of DEFAULT as the audio encode and decoder.
Platforms affected
Android
What does this PR do?
Puts the media encoder/decoder back to DEFAULT
What testing has been done on this change?
I created a repo that shows the current media plugin failing. Applying the code in this pull request will show it passing.
https://github.com/medsurvey/cordova-media-bug
The problem seems to be that somehow the encoder and decoder are set to different encoding types and are not compatible. Additionally its assuming an encoder is available on the platform and since the interface to the this object does not allow a way to specifying encoding I feel like the default may have been more appropriate.
Checklist
Could not complete these as I don't have access