feat: add request headers and cookies as new options#1024
Open
lubbo wants to merge 4 commits intoapache:masterfrom
Open
feat: add request headers and cookies as new options#1024lubbo wants to merge 4 commits intoapache:masterfrom
lubbo wants to merge 4 commits intoapache:masterfrom
Conversation
This was referenced Sep 26, 2023
Author
|
Hi @janpio, can you take a look at this PR? |
|
Setting headers is a feature that I would also very much like to see :) |
|
+1 to @Crylion This would be a really great addition! :) |
|
Is it possible to merge this? |
This comment was marked as abuse.
This comment was marked as abuse.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
Motivation and Context
It's currently not possible to set cookies and request headers when opening the IAB.
Description
I'm adding two new options:
Limitations
Testing
From JS side open the IAB with following options:
Checklist
(platform)if this change only applies to one platform (e.g.(android))