GH-1022 android: enable zoom without on-screen controls#1023
Open
reznej wants to merge 2 commits intoapache:masterfrom
Open
GH-1022 android: enable zoom without on-screen controls#1023reznej wants to merge 2 commits intoapache:masterfrom
reznej wants to merge 2 commits intoapache:masterfrom
Conversation
ArikEpstein
pushed a commit
to ArikEpstein/cordova-plugin-inappbrowser
that referenced
this pull request
Jan 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
Closes Issue #1022
Description
This change adds an settable option
zoomcontrolsin addition tozoomat initialisation of the Inappbrowser instance. This enables a separation between zoom-controls (pinch-to-zoom) and additionally showing zoom-buttons to manually adjust zooming.Testing
Ran manual tests with different combinations for parameters
zoomandzoomcontrols.Checklist
(platform)if this change only applies to one platform (e.g.(android))