Align ReflectionDiffBuilder with AbstractReflection and add cycle detection - #1778
Merged
garydgregory merged 1 commit intoAug 23, 2026
Conversation
garydgregory
added a commit
that referenced
this pull request
Aug 23, 2026
detection (#1778). - Fix action order. - Sort members.
garydgregory
added a commit
that referenced
this pull request
Aug 23, 2026
detection (#1778). - Add unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align
ReflectionDiffBuilderwithAbstractReflection:ReflectionDiffBuilder<T>now extendsAbstractReflectionfor consistency withEqualsBuilder,HashCodeBuilder,CompareToBuilder, andToStringBuilder.ReflectionDiffBuilder.Builder<T>extendsAbstractReflection.AbstractBuilder<Builder<T>>and implementsSupplier<ReflectionDiffBuilder<T>>viaget(), inheritingsetForceAccessible(boolean).readFieldwithAbstractReflection.setAccessible(field)andReflection.getUnchecked(field, target)with runtime module safety.Cycle Detection & StackOverflow Protection:
REGISTRY) to track object pairs during reflection diffing.ReflectionDiffBuilder.build()andDiffBuilderconstructor to avoidStackOverflowErroron self-referential or mutually-referential object graphs.Tests & Changes:
ReflectionDiffBuilderTestcovering self-referential cycles, mutually-referential cycles, asymmetric cycles, and builder configuration.src/changes/changes.xml.