Skip to content

Keep StopWatch.formatSplitTime from clamping splits to int millis #1777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
garydgregory merged 1 commit into from
Aug 22, 2026
+12 −1
Merged

Keep StopWatch.formatSplitTime from clamping splits to int millis #1777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/apache/commons/lang3/time/StopWatch.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ public StopWatch(final String message) {
* @since 3.10
*/
public String formatSplitTime() {
return DurationFormatUtils.formatDurationHMS(DurationUtils.toMillisInt(getSplitDuration()));
return DurationFormatUtils.formatDurationHMS(DurationUtils.toMillisLong(getSplitDuration()));
}

/**
Expand Down
11 changes: 11 additions & 0 deletions src/test/java/org/apache/commons/lang3/time/StopWatchTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,17 @@ void testFormatSplitTime() {
assertTrue(formatSplitTime.startsWith(ZERO_HOURS_PREFIX), "formatSplitTime");
}

@Test
void testFormatSplitTimeExceedingIntMillis() throws Exception {
final StopWatch watch = StopWatch.createStarted();
// Backdate the start so the split spans more than Integer.MAX_VALUE milliseconds (about 24.86 days).
FieldUtils.writeField(watch, "startTimeNanos", System.nanoTime() - TimeUnit.DAYS.toNanos(30), true);
watch.split();
final long splitMillis = watch.getSplitDuration().toMillis();
assertTrue(splitMillis > Integer.MAX_VALUE, "precondition: split must exceed Integer.MAX_VALUE millis");
assertEquals(DurationFormatUtils.formatDurationHMS(splitMillis), watch.formatSplitTime(), "formatSplitTime");
}

@Test
void testFormatSplitTimeWithMessage() {
final StopWatch watch = new StopWatch(MESSAGE);
Expand Down
Loading