Keep StringUtils left, right, mid, and overlay off surrogate pair boundaries - #1776
Merged
garydgregory merged 1 commit intoAug 22, 2026
Conversation
|
JAIPilot Cloud reviewed exact head 164ab3a and found one small behavior-preserving cleanup: StringUtils.mid() computes the same surrogate-safe start position in both branches. I opened a draft against the contributor branch: Alwaysgaurav1#1 The same 194 focused tests passed before/after, and the full Maven build passed with Checkstyle, SpotBugs, PMD, japicmp, and Javadoc. AI-assisted and independently scope-reviewed; no performance claim. |
Member
|
Hello @Alwaysgaurav1 |
Alwaysgaurav1
force-pushed
the
fix/keep-left-right-mid-off-surrogates
branch
from
August 22, 2026 16:07
164ab3a to
0e049ac
Compare
Contributor
Author
|
Hi @garydgregory, I have rebased the branch on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevents
StringUtils.left,StringUtils.right,StringUtils.mid, andStringUtils.overlayfrom splitting UTF-16 surrogate pairs into malformed lone surrogates.Details of Changes
StringUtils.left: Backs off the cut by 1 whensplitsSurrogatePairis true to avoid trailing lone high surrogates.StringUtils.right: Advances start by 1 whensplitsSurrogatePairis true to avoid leading lone low surrogates.StringUtils.mid: Adjusts start and end boundaries to keep cuts off the middle of surrogate pairs.StringUtils.overlay: Adjusts replacement span boundaries off surrogate pairs.StringUtilsSubstringTestandStringUtilsTest.src/changes/changes.xml.