[Veeam] disable jobs but keep backups

[SadiJr]

Description

Using the VMWare hypervisor, with the Veeam plugin active, it is not possible to remove the VM from its Backup Offering without removing its backups. To resolve this limitation, a new parameter has been added to the removeVirtualMachineFromBackupOffering API to allow users to disable the job but keep Veeam backups. So, when removing a VM from a Backup Offering, it is possible to pass the forced parameter to true, which will remove the job and the backups. Otherwise, the job will just be disabled and the backups will be kept.

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

How Has This Been Tested?

It was tested in a local lab:

1. I created a new VM and attached this VM to a Backup Offering;
2. I make some manual backups;
3. I removed this VM from the backup offering, without using the force option as false, and checked if, in Veeam, the job was still there, in the disabled state, and if the backups were still stored too;
4. I repeat this process, but using true in force option and check if the backups and job are deleted in Veeam.

[acs-robot]

Found UI changes, kicking a new UI QA build
@blueorangutan ui

[blueorangutan]

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6589 (SL-JID-2033)

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[acs-robot]

Found UI changes, kicking a new UI QA build
@blueorangutan ui

[blueorangutan]

@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6589 (SL-JID-2068)

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✖️ el7 ✔️ el8 ✖️ debian ✖️ suse15. SL-JID 3904

[blueorangutan]

Packaging result: ✖️ el7 ✔️ el8 ✖️ debian ✖️ suse15. SL-JID 3908

[blueorangutan]

Packaging result: ✖️ el7 ✔️ el8 ✖️ debian ✖️ suse15. SL-JID 3914

[blueorangutan]

Packaging result: ✖️ el7 ✖️ el8 ✖️ debian ✔️ suse15. SL-JID 3918

[blueorangutan]

Packaging result: ✔️ el7 ✔️ el8 ✔️ debian ✔️ suse15. SL-JID 3937

[DaanHoogland]

@blueorangutan test matrix

[blueorangutan]

@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-4642)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36946 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6589-t4642-xenserver-71.zip
Smoke tests completed. 101 look OK, 0 have errors
Only failed tests results shown below:

Test	Result	Time (s)	Test File

[BryanMLima]

@DaanHoogland, could you trigger the marvin tests here?

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11455

[DaanHoogland]

@BryanMLima , as this a Veeam fix , should it be a vmware run?

[BryanMLima]

@BryanMLima , as this a Veeam fix , should it be a vmware run?

Yep, it should be.

[DaanHoogland]

@blueorangutan test ol9 vmware-70u3

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol9 mgmt + vmware-70u3) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-11735)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol9
Total time taken: 56942 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6589-t11735-vmware-70u3.zip
Smoke tests completed. 137 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_deploy_more_vms_than_limit_allows	Error	148.87	test_deploy_vms_in_parallel.py
test_01_deployVMInSharedNetwork	Error	144.83	test_network.py
test_02_restore_vm_with_disk_offering	Error	62.06	test_restore_vm.py
test_03_restore_vm_with_disk_offering_custom_size	Error	56.98	test_restore_vm.py
test_08_reboot_cpvm	Failure	23.15	test_ssvm.py
test_11_destroy_ssvm	Error	6.33	test_ssvm.py

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

[hsato03]

@blueorangutan package

[blueorangutan]

@hsato03 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12954

[DaanHoogland]

@blueorangutan test ol9 vmware-70u3

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol9 mgmt + vmware-70u3) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian Build Failed (tid-12902)

[DaanHoogland]

@blueorangutan test ol9 vmware-80u3

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol9 mgmt + vmware-80u3) has been kicked to run smoke tests

[github-actions]

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.