KVM: add configurable MAC/IP script hook for static ARP/NDP and routes#13495
KVM: add configurable MAC/IP script hook for static ARP/NDP and routes#13495wido wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13495 +/- ##
============================================
+ Coverage 17.68% 18.94% +1.26%
- Complexity 15793 18376 +2583
============================================
Files 5922 6192 +270
Lines 533123 556600 +23477
Branches 65201 67964 +2763
============================================
+ Hits 94268 105450 +11182
- Misses 428212 439572 +11360
- Partials 10643 11578 +935
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
DaanHoogland
left a comment
There was a problem hiding this comment.
clgtm, why not set your script as default value for the property @wido ? (if it is well tested and robust, that is)
Thanks, the reason the script does not always execute is that it could break existing setups. Therefor it is not set by default. |
yeah, that is what I meant by robust ;) np, fine like this as well. |
baae859 to
ac65b6a
Compare
Introduces a new agent.properties option `vm.network.macip.static` (false by default) that makes BridgeVifDriver invoke on modifymacip.sh on every NIC plug (VM start) and unplug (VM stop). This is very useful in EVPN+VXLAN environments as it can reduce BUM traffic. By setting static ARP/NDP entries bridges can be configured using 'neigh_suppress on' as the ARP/NDP entries are already set statically by CloudStack. Setting 'neigh_suppress on' requires a manual change in the modifyvxlan.sh script as this is not the default behavior.
Introduces a new agent.properties option
vm.network.macip.script(absolute path, disabled by default) that BridgeVifDriver invokes on every NIC plug (VM start) and unplug (VM stop).This is very useful in EVPN+VXLAN environments as it can reduce BUM traffic. By setting static ARP/NDP entries bridges can be configured using 'neigh_suppress on' as the ARP/NDP entries are already set statically by CloudStack.