Skip to content

kvm: fix wrong CheckVirtualMachineAnswer when vm does not exist#12928

Draft
weizhouapache wants to merge 3 commits intoapache:4.22from
weizhouapache:4.22-fix-virsh-destroy-vm-ha
Draft

kvm: fix wrong CheckVirtualMachineAnswer when vm does not exist#12928
weizhouapache wants to merge 3 commits intoapache:4.22from
weizhouapache:4.22-fix-virsh-destroy-vm-ha

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

Description

This PR should fix #12920

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache
Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.60%. Comparing base (59b6c32) to head (8fb2437).

Additional details and impacted files
@@             Coverage Diff              @@
##               4.22   #12928      +/-   ##
============================================
- Coverage     17.60%   17.60%   -0.01%     
- Complexity    15676    15678       +2     
============================================
  Files          5918     5918              
  Lines        531667   531667              
  Branches      65001    65001              
============================================
- Hits          93617    93611       -6     
- Misses       427491   427501      +10     
+ Partials      10559    10555       -4     
Flag Coverage Δ
uitests 3.70% <ø> (ø)
unittests 18.67% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17307

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@weizhouapache
Copy link
Copy Markdown
Member Author

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

…/resource/wrapper/LibvirtCheckVirtualMachineCommandWrapperTest.java

Co-authored-by: dahn <daan.hoogland@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KVM HA: VM remains Running after virsh destroy; PowerReportMissing schedules HA but KVMInvestigator reports alive=true and restart is cancelled

3 participants