Skip to content

Conversation

@YLChen-007
Copy link

Description

This PR fixes HMAC Signatures and API Keys Logged in Plaintext Across Authentication Components #11988

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland DaanHoogland added this to the 4.20.3 milestone Nov 7, 2025
@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.18%. Comparing base (2954e96) to head (4317265).
⚠️ Report is 1 commits behind head on 4.20.

Files with missing lines Patch % Lines
...cloud/storage/template/HttpTemplateDownloader.java 0.00% 1 Missing ⚠️
...c/main/java/com/cloud/upgrade/DatabaseCreator.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #12021      +/-   ##
============================================
- Coverage     16.18%   16.18%   -0.01%     
+ Complexity    13305    13303       -2     
============================================
  Files          5657     5657              
  Lines        498471   498471              
  Branches      60492    60492              
============================================
- Hits          80697    80696       -1     
- Misses       408793   408794       +1     
  Partials       8981     8981              
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 17.04% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland DaanHoogland force-pushed the my-fix-420-mask-sensitive-information branch from c1885b9 to 78a7ed7 Compare November 7, 2025 14:07
@DaanHoogland DaanHoogland reopened this Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants