-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix HMAC Signatures and API Keys Logged in Plaintext #12021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.20
Are you sure you want to change the base?
fix HMAC Signatures and API Keys Logged in Plaintext #12021
Conversation
DaanHoogland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
core/src/main/java/com/cloud/storage/template/HttpTemplateDownloader.java
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #12021 +/- ##
============================================
- Coverage 16.18% 16.18% -0.01%
+ Complexity 13305 13303 -2
============================================
Files 5657 5657
Lines 498471 498471
Branches 60492 60492
============================================
- Hits 80697 80696 -1
- Misses 408793 408794 +1
Partials 8981 8981
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…loader.java Co-authored-by: dahn <[email protected]>
c1885b9 to
78a7ed7
Compare
Description
This PR fixes HMAC Signatures and API Keys Logged in Plaintext Across Authentication Components #11988