sensitive information leak to log #12018
Open
+16
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #12018 +/- ##
=============================================
- Coverage 16.18% 4.00% -12.19%
=============================================
Files 5657 402 -5255
Lines 498466 32665 -465801
Branches 60491 5808 -54683
=============================================
- Hits 80696 1309 -79387
+ Misses 408789 31203 -377586
+ Partials 8981 153 -8828
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
DaanHoogland
approved these changes
Nov 7, 2025
Contributor
DaanHoogland
left a comment
DaanHoogland
left a comment
There was a problem hiding this comment.
clgtm, all comments nitpicking
agent/src/main/java/com/cloud/agent/resource/consoleproxy/ConsoleProxyResource.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/cloud/storage/template/HttpTemplateDownloader.java
Outdated
Show resolved
Hide resolved
engine/schema/src/main/java/com/cloud/upgrade/DatabaseCreator.java
Outdated
Show resolved
Hide resolved
...ors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalDnsmasqResource.java
Outdated
Show resolved
Hide resolved
...ors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalDnsmasqResource.java
Outdated
Show resolved
Hide resolved
...aremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalKickStartPxeResource.java
Outdated
Show resolved
Hide resolved
...ors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalPingPxeResource.java
Outdated
Show resolved
Hide resolved
...ors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalPingPxeResource.java
Outdated
Show resolved
Hide resolved
...ors/baremetal/src/main/java/com/cloud/baremetal/networkservice/BaremetalPingPxeResource.java
Outdated
Show resolved
Hide resolved
…oleProxyResource.java Co-authored-by: dahn <[email protected]>
…loader.java Co-authored-by: dahn <[email protected]>
…java Co-authored-by: dahn <[email protected]>
…l/networkservice/BaremetalDnsmasqResource.java Co-authored-by: dahn <[email protected]>
…l/networkservice/BaremetalDnsmasqResource.java Co-authored-by: dahn <[email protected]>
…l/networkservice/BaremetalKickStartPxeResource.java Co-authored-by: dahn <[email protected]>
…l/networkservice/BaremetalPingPxeResource.java Co-authored-by: dahn <[email protected]>
…l/networkservice/BaremetalPingPxeResource.java Co-authored-by: dahn <[email protected]>
…l/networkservice/BaremetalPingPxeResource.java Co-authored-by: dahn <[email protected]>
Co-authored-by: dahn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixed sensitive information leak to log #11985