Skip to content

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Nov 6, 2025

Description

Fixes #10950

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@shwstppr
Copy link
Contributor Author

shwstppr commented Nov 6, 2025

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.55%. Comparing base (8c86f24) to head (e31eb4f).

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12003      +/-   ##
============================================
- Coverage     17.55%   17.55%   -0.01%     
+ Complexity    15543    15537       -6     
============================================
  Files          5910     5910              
  Lines        529334   529334              
  Branches      64654    64654              
============================================
- Hits          92944    92905      -39     
- Misses       425933   425973      +40     
+ Partials      10457    10456       -1     
Flag Coverage Δ
uitests 3.58% <ø> (ø)
unittests 18.61% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shwstppr shwstppr force-pushed the fix-vol-offering-update branch 2 times, most recently from f2b625c to e2ee575 Compare November 6, 2025 10:50
@shwstppr shwstppr changed the title server: fix volume offering not updated after resize server: fix volume offering not updated after offering change Nov 6, 2025
@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15656

@shwstppr shwstppr marked this pull request as ready for review November 10, 2025 06:35
@shwstppr
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15698

@DaanHoogland DaanHoogland added this to the 4.23 milestone Nov 10, 2025
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

@abh1sar , can you have a look/test?

Copy link
Collaborator

@abh1sar abh1sar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. The offering is getting updated as expected.
LGTM.

Screen.Recording.2025-11-11.at.10.36.04.AM.mov

@DaanHoogland
Copy link
Contributor

@abh1sar @shwstppr , does it make sense to rebase on 4.20?

@shwstppr
Copy link
Contributor Author

@DaanHoogland done

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15715

@DaanHoogland
Copy link
Contributor

@blueorangutan test

@DaanHoogland DaanHoogland modified the milestones: 4.23, 4.20.3 Nov 11, 2025
@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-14798)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 51283 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12003-t14798-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@DaanHoogland DaanHoogland merged commit f0a0936 into apache:4.20 Nov 12, 2025
1 check passed
@DaanHoogland DaanHoogland deleted the fix-vol-offering-update branch November 12, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI still shows old disk offering after changing volume disk offering

4 participants