Skip to content

Conversation

@erikbocks
Copy link
Collaborator

Description

This PR fixes the finalyze typo in the AccountService.finalyzeAccountId() method signature.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Screenshots (if appropriate):

How Has This Been Tested?

After changing the code, I compiled it with maven, ran the tests and validated that the process was successful.

@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 13.33333% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.56%. Comparing base (dbda673) to head (bdaa5c8).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ache/cloudstack/network/RoutedIpv4ManagerImpl.java 33.33% 4 Missing ⚠️
.../command/user/resource/UpdateResourceLimitCmd.java 0.00% 2 Missing ⚠️
...i/command/admin/vm/ImportUnmanagedInstanceCmd.java 0.00% 1 Missing ⚠️
...nd/user/autoscale/CreateAutoScaleVmProfileCmd.java 0.00% 1 Missing ⚠️
...api/command/user/autoscale/CreateConditionCmd.java 0.00% 1 Missing ⚠️
...stack/api/command/user/bucket/CreateBucketCmd.java 0.00% 1 Missing ⚠️
...api/command/user/iso/GetUploadParamsForIsoCmd.java 0.00% 1 Missing ⚠️
...loudstack/api/command/user/iso/RegisterIsoCmd.java 0.00% 1 Missing ⚠️
...ack/api/command/user/network/CreateNetworkCmd.java 0.00% 1 Missing ⚠️
...egion/ha/gslb/CreateGlobalLoadBalancerRuleCmd.java 0.00% 1 Missing ⚠️
... and 25 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11990      +/-   ##
============================================
- Coverage     17.56%   17.56%   -0.01%     
+ Complexity    15544    15542       -2     
============================================
  Files          5909     5909              
  Lines        529056   529059       +3     
  Branches      64617    64617              
============================================
- Hits          92945    92917      -28     
- Misses       425656   425688      +32     
+ Partials      10455    10454       -1     
Flag Coverage Δ
uitests 3.58% <ø> (-0.01%) ⬇️
unittests 18.62% <13.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bernardodemarco
Copy link
Member

@erikbocks, apparently there is a build/compilation error:

Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile (default-testCompile) on project cloud-server: Compilation failure: Compilation failure: 
Error:  /home/runner/work/cloudstack/cloudstack/server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java:[3937,27] error: cannot find symbol
Error:    symbol:   method finalyzeAccountId(String,Long,Long,boolean)
Error:    location: variable accountService of type AccountService
Error:  /home/runner/work/cloudstack/cloudstack/server/src/test/java/com/cloud/vm/UserVmManagerImplTest.java:[4003,27] error: cannot find symbol
Error:    symbol:   method finalyzeAccountId(String,Long,Long,boolean)
Error:    location: variable accountService of type AccountService
Error:  -> [Help 1]

Could you verify it?

Copy link
Collaborator

@lucas-a-martins lucas-a-martins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants