Skip to content

ui: fix build on latest Ubuntu and macOS #11259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rohityadavcloud
Copy link
Member

@rohityadavcloud rohityadavcloud commented Jul 22, 2025

This fixes UI build, so it can build against nodejs 20.x/LTS.

Tested on macOS 15 and Ubuntu 25.04.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

This fixes UI build, so it can build against nodejs 20.x/LTS.

Signed-off-by: Rohit Yadav <[email protected]>
@rohityadavcloud
Copy link
Member Author

This could be moved to 4.22 as this isn't urgent. cc @sureshanaparti

@blueorangutan ui

@blueorangutan
Copy link

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copy link

codecov bot commented Jul 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.57%. Comparing base (6ad9296) to head (2b1e505).

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11259      +/-   ##
============================================
- Coverage     16.57%   16.57%   -0.01%     
- Complexity    14057    14059       +2     
============================================
  Files          5772     5772              
  Lines        512939   512939              
  Branches      62305    62305              
============================================
- Hits          85033    85025       -8     
- Misses       418425   418433       +8     
  Partials       9481     9481              
Flag Coverage Δ
uitests 3.89% <ø> (ø)
unittests 17.47% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11259 (QA-JID-677)

@DaanHoogland
Copy link
Contributor

@rohityadavcloud can we include updates of nodejs packages? lots of them have updates and the dependabot updates never pass any CI.

@rohityadavcloud
Copy link
Member Author

I think so @DaanHoogland - as nodejs/npm are simply the build tools and dev-dependencies are also used for building purposes and not used in the exported artifacts. I would suggest we hold this, and include for 4.22 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants