-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ui: fix build on latest Ubuntu and macOS #11259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This fixes UI build, so it can build against nodejs 20.x/LTS. Signed-off-by: Rohit Yadav <[email protected]>
This could be moved to 4.22 as this isn't urgent. cc @sureshanaparti |
@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11259 +/- ##
============================================
- Coverage 16.57% 16.57% -0.01%
- Complexity 14057 14059 +2
============================================
Files 5772 5772
Lines 512939 512939
Branches 62305 62305
============================================
- Hits 85033 85025 -8
- Misses 418425 418433 +8
Partials 9481 9481
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
UI build: ✔️ |
@rohityadavcloud can we include updates of nodejs packages? lots of them have updates and the dependabot updates never pass any CI. |
I think so @DaanHoogland - as nodejs/npm are simply the build tools and dev-dependencies are also used for building purposes and not used in the exported artifacts. I would suggest we hold this, and include for 4.22 instead. |
This fixes UI build, so it can build against nodejs 20.x/LTS.
Tested on macOS 15 and Ubuntu 25.04.
Types of changes