Support Direct Download on Ceph primary storage #11069
Conversation
nvazquez
requested review from
rohityadavcloud,
wido,
DaanHoogland,
sureshanaparti and
slavkap
|
@blueorangutan package |
|
@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11069 +/- ##
============================================
- Coverage 16.57% 16.57% -0.01%
Complexity 13967 13967
============================================
Files 5743 5743
Lines 510468 510492 +24
Branches 62073 62074 +1
============================================
+ Hits 84616 84617 +1
- Misses 416390 416413 +23
Partials 9462 9462
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13869 |
|
Great work! Good to see progress here. But requiring ceph.conf on the node will break a lot of things. As CloudStack supports multiple Ceph RBD pools, how will we handle this? We can't guarantee that there will be only one Ceph cluster. Why don't we pass these arguments to qemu-img? |
| destDisk.setFormat(PhysicalDiskFormat.RAW); | ||
| destDisk.setSize(virtualSize); | ||
| destDisk.setVirtualSize(virtualSize); | ||
| QemuImgFile destFile = new QemuImgFile(KVMPhysicalDisk.RBDStringBuilder(destPool, destDisk.getPath())); |
There was a problem hiding this comment.
This line here makes that it doesn't need ceph.conf, right?
There was a problem hiding this comment.
In my case the logs indicated that qemu img was looking for ceph.conf at diferent directories and failed as it couldn't find it. Probably it could be some misconfiguration at my side, will explore
There was a problem hiding this comment.
I was initially testing on 4.20 branch and the RBDStringBuilder was accepting more parameters, I have now recreated the env using this PR packages and I don't observe the failure anymore
|
Thanks @wido - sorry I was not aware of this, I added the |
|
@wido I have recreated my CloudStack environment from the latest packages without copying the ceph.conf files to the KVM hosts. Now I'm not hitting any issue on the qemu-img convertion and direct download templates are successfully deployed. I have updated the PR description to remove the need of ceph.conf file. |
Description
This PR adds support for Direct Downloads on Ceph primary storage. Its logic is replicating the logic added on the Storpool support for Direct download #9833 but adapted to Ceph.
Fixes: #3065
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Tested on KVM env with NFS and Ceph primary pool
Created a service offering containing a storage tag matching the Ceph pool
Registered template using 'Direct download' option
Deploy VM -> Observe the VM is deployed and booted, disk downloaded to temporary location and converted to the Ceph destination
How did you try to break this feature and the system with this change?