Skip to content

kvm: consider Debian same as Ubuntu #10917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 17, 2025
Merged

kvm: consider Debian same as Ubuntu #10917

merged 3 commits into from
Jul 17, 2025

Conversation

weizhouapache
Copy link
Member

Description

This PR fixes the issue that UEFI is always false for debian hosts.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache weizhouapache added this to the 4.20.1 milestone May 26, 2025
@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

DaanHoogland
DaanHoogland approved these changes May 26, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

Pearl1594
Pearl1594 approved these changes May 26, 2025
View reviewed changes
Copy link
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@codecov Codecov
Copy link

codecov bot commented May 26, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.

Project coverage is 16.15%. Comparing base (9688cbb) to head (3a7b6c9).
Report is 4 commits behind head on 4.20.

Files with missing lines Patch % Lines
...ervisor/kvm/resource/LibvirtComputingResource.java 0.00% 6 Missing ⚠️
...m/resource/wrapper/LibvirtReadyCommandWrapper.java 33.33% 0 Missing and 2 partials ⚠️
...per/LibvirtCheckConvertInstanceCommandWrapper.java 0.00% 0 Missing and 1 partial ⚠️
.../wrapper/LibvirtConvertInstanceCommandWrapper.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               4.20   #10917   +/-   ##
=========================================
  Coverage     16.15%   16.15%           
+ Complexity    13274    13272    -2     
=========================================
  Files          5656     5656           
  Lines        497728   497729    +1     
  Branches      60360    60362    +2     
=========================================
+ Hits          80420    80421    +1     
  Misses       408357   408357           
  Partials       8951     8951
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 17.00% <9.09%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13511

@DaanHoogland
Copy link
Contributor

@blueorangutan help

@blueorangutan
Copy link

@DaanHoogland [SL] I understand these words: "help", "hello", "thanks", "package", "test"
Test command usage: test [mgmt os] [hypervisor] [keepEnv] [qemuEv] [basicZone|securityGroups]
Mgmt OS options: ['ol8', 'ol9', 'debian12', 'rocky8', 'alma9', 'suse15', 'centos7', 'centos6', 'alma8', 'ubuntu18', 'ubuntu22', 'ubuntu20', 'ubuntu24']
Hypervisor options: ['kvm-centos6', 'kvm-centos7', 'kvm-rocky8', 'kvm-ol8', 'kvm-ol9', 'kvm-alma8', 'kvm-alma9', 'kvm-ubuntu18', 'kvm-ubuntu20', 'kvm-ubuntu22', 'kvm-ubuntu24', 'kvm-debian12', 'kvm-suse15', 'vmware-55u3', 'vmware-60u2', 'vmware-65u2', 'vmware-67u3', 'vmware-70u1', 'vmware-70u2', 'vmware-70u3', 'vmware-80', 'vmware-80u1', 'vmware-80u2', 'vmware-80u3', 'xenserver-65sp1', 'xenserver-71', 'xenserver-74', 'xenserver-84', 'xcpng74', 'xcpng76', 'xcpng80', 'xcpng81', 'xcpng82', 'xcpng83']
Note: when keepEnv is passed, you need to specify mgmt server os and hypervisor or use the matrix command.
when qemuEv is passed, it will deploy KVM hyperviosr hosts with qemu-kvm-ev, else it will default to stock qemu.
When basicZone and/or securityGroups are passed it will create a zone of the last type specified (default is Advanced)
Package command usage: package [all(default value),kvm,xen,vmware,hyperv,ovm] - a comma separated list can be passed with package command to bundle the required hypervisor's systemVM templates. Not passing any argument will bundle all - kvm,xen and vmware templates.

Blessed contributors for kicking Trillian test jobs: ['rohityadavcloud', 'shwstppr', 'vishesh92', 'Pearl1594', 'harikrishna-patnala', 'nvazquez', 'DaanHoogland', 'weizhouapache', 'borisstoyanov', 'vladimirpetrov', 'kiranchavala', 'andrijapanicsb', 'NuxRo', 'rajujith', 'alexandremattioli', 'sureshanaparti', 'abh1sar', 'sudo87', 'rosi-shapeblue']

@DaanHoogland
Copy link
Contributor

@blueorangutan test debian12 kvm-debian12

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (debian12 mgmt + kvm-debian12) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-13401)
Environment: kvm-debian12 (x2), Advanced Networking with Mgmt server d12
Total time taken: 56514 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10917-t13401-kvm-debian12.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_oobm_background_powerstate_sync Failure 22.01 test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones Error 36.63 test_outofbandmanagement.py
test_oobm_issue_power_cycle Error 18.99 test_outofbandmanagement.py
test_oobm_issue_power_off Error 19.96 test_outofbandmanagement.py
test_oobm_issue_power_on Error 20.01 test_outofbandmanagement.py
test_oobm_issue_power_reset Error 19.98 test_outofbandmanagement.py
test_oobm_issue_power_soft Error 20.04 test_outofbandmanagement.py
test_oobm_issue_power_status Error 19.00 test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership Failure 176.93 test_outofbandmanagement.py
test_oobm_zchange_password Error 7.57 test_outofbandmanagement.py
test_hostha_kvm_host_degraded Error 9.74 test_hostha_kvm.py
test_hostha_kvm_host_fencing Error 10.67 test_hostha_kvm.py
test_hostha_kvm_host_recovering Error 12.90 test_hostha_kvm.py

@weizhouapache weizhouapache marked this pull request as ready for review May 27, 2025 06:51
@blueorangutan
Copy link

[SF] Trillian test result (tid-13407)
Environment: kvm-debian12 (x2), Advanced Networking with Mgmt server d12
Total time taken: 59351 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10917-t13407-kvm-debian12.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_oobm_background_powerstate_sync Failure 22.02 test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones Error 37.88 test_outofbandmanagement.py
test_oobm_issue_power_cycle Error 20.09 test_outofbandmanagement.py
test_oobm_issue_power_off Error 20.06 test_outofbandmanagement.py
test_oobm_issue_power_on Error 19.01 test_outofbandmanagement.py
test_oobm_issue_power_reset Error 19.00 test_outofbandmanagement.py
test_oobm_issue_power_soft Error 20.07 test_outofbandmanagement.py
test_oobm_issue_power_status Error 20.03 test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership Failure 178.26 test_outofbandmanagement.py
test_oobm_zchange_password Error 7.52 test_outofbandmanagement.py
test_hostha_kvm_host_degraded Error 13.12 test_hostha_kvm.py
test_hostha_kvm_host_fencing Error 12.18 test_hostha_kvm.py
test_hostha_kvm_host_recovering Error 12.23 test_hostha_kvm.py

@Pearl1594 Pearl1594 modified the milestones: 4.20.1, 4.20.2 Jun 3, 2025
@weizhouapache @sureshanaparti
Update plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm…
87f83b0 
…/resource/LibvirtComputingResource.java

Co-authored-by: Suresh Kumar Anaparti <[email protected]>
@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 14069

@weizhouapache
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14074

@weizhouapache
Copy link
Member Author

@blueorangutan test debian12 kvm-debian12

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (debian12 mgmt + kvm-debian12) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-13709)
Environment: kvm-debian12 (x2), Advanced Networking with Mgmt server d12
Total time taken: 62577 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10917-t13709-kvm-debian12.zip
Smoke tests completed. 137 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestIpv4Routing>:setup Error 0.00 test_ipv4_routing.py
test_04_list_domains_level_filter Failure 0.04 test_list_domains.py
test_05_list_domains_no_filter Failure 0.03 test_list_domains.py
test_oobm_background_powerstate_sync Failure 21.82 test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones Error 31.95 test_outofbandmanagement.py
test_oobm_issue_power_cycle Error 19.85 test_outofbandmanagement.py
test_oobm_issue_power_off Error 19.82 test_outofbandmanagement.py
test_oobm_issue_power_on Error 19.83 test_outofbandmanagement.py
test_oobm_issue_power_reset Error 19.89 test_outofbandmanagement.py
test_oobm_issue_power_soft Error 19.81 test_outofbandmanagement.py
test_oobm_issue_power_status Error 19.81 test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership Failure 176.61 test_outofbandmanagement.py
test_oobm_zchange_password Error 7.50 test_outofbandmanagement.py
test_hostha_kvm_host_degraded Error 10.80 test_hostha_kvm.py
test_hostha_kvm_host_fencing Error 12.20 test_hostha_kvm.py
test_hostha_kvm_host_recovering Error 9.82 test_hostha_kvm.py

@weizhouapache
Copy link
Member Author

@blueorangutan test debian12 kvm-debian12

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (debian12 mgmt + kvm-debian12) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-13731)
Environment: kvm-debian12 (x2), Advanced Networking with Mgmt server d12
Total time taken: 60613 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10917-t13731-kvm-debian12.zip
Smoke tests completed. 137 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestClusterDRS>:setup Error 0.00 test_cluster_drs.py
test_list_system_vms_metrics_history Failure 0.27 test_metrics_api.py
test_oobm_background_powerstate_sync Failure 21.92 test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones Error 37.39 test_outofbandmanagement.py
test_oobm_issue_power_cycle Error 19.96 test_outofbandmanagement.py
test_oobm_issue_power_off Error 18.86 test_outofbandmanagement.py
test_oobm_issue_power_on Error 18.89 test_outofbandmanagement.py
test_oobm_issue_power_reset Error 19.95 test_outofbandmanagement.py
test_oobm_issue_power_soft Error 19.92 test_outofbandmanagement.py
test_oobm_issue_power_status Error 18.87 test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership Failure 176.82 test_outofbandmanagement.py
test_oobm_zchange_password Error 6.49 test_outofbandmanagement.py
test_hostha_kvm_host_degraded Error 11.85 test_hostha_kvm.py
test_hostha_kvm_host_fencing Error 9.70 test_hostha_kvm.py
test_hostha_kvm_host_recovering Error 10.70 test_hostha_kvm.py

@sureshanaparti
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14194

@DaanHoogland
Copy link
Contributor

@blueorangutan test debian12 kvm-debian12

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (debian12 mgmt + kvm-debian12) has been kicked to run smoke tests

@DaanHoogland
Copy link
Contributor

@blueorangutan test ubuntu24 kvm-ubuntu24

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ubuntu24 mgmt + kvm-ubuntu24) has been kicked to run smoke tests

@blueorangutan
Copy link

[SF] Trillian test result (tid-13787)
Environment: kvm-debian12 (x2), Advanced Networking with Mgmt server d12
Total time taken: 56089 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10917-t13787-kvm-debian12.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_oobm_background_powerstate_sync Failure 21.92 test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones Error 36.67 test_outofbandmanagement.py
test_oobm_issue_power_cycle Error 19.96 test_outofbandmanagement.py
test_oobm_issue_power_off Error 20.46 test_outofbandmanagement.py
test_oobm_issue_power_on Error 19.96 test_outofbandmanagement.py
test_oobm_issue_power_reset Error 19.96 test_outofbandmanagement.py
test_oobm_issue_power_soft Error 19.93 test_outofbandmanagement.py
test_oobm_issue_power_status Error 18.88 test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership Failure 176.87 test_outofbandmanagement.py
test_oobm_zchange_password Error 6.51 test_outofbandmanagement.py
test_hostha_kvm_host_degraded Error 9.76 test_hostha_kvm.py
test_hostha_kvm_host_fencing Error 10.19 test_hostha_kvm.py
test_hostha_kvm_host_recovering Error 13.00 test_hostha_kvm.py

@blueorangutan
Copy link

[SF] Trillian test result (tid-13789)
Environment: kvm-ubuntu24 (x2), Advanced Networking with Mgmt server u24
Total time taken: 61463 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10917-t13789-kvm-ubuntu24.zip
Smoke tests completed. 138 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_oobm_background_powerstate_sync Failure 22.05 test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones Error 36.60 test_outofbandmanagement.py
test_oobm_issue_power_cycle Error 19.98 test_outofbandmanagement.py
test_oobm_issue_power_off Error 19.95 test_outofbandmanagement.py
test_oobm_issue_power_on Error 19.94 test_outofbandmanagement.py
test_oobm_issue_power_reset Error 19.98 test_outofbandmanagement.py
test_oobm_issue_power_soft Error 19.97 test_outofbandmanagement.py
test_oobm_issue_power_status Error 20.01 test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership Failure 176.99 test_outofbandmanagement.py
test_oobm_zchange_password Error 7.64 test_outofbandmanagement.py
test_06_download_detached_volume Failure 439.86 test_volumes.py
test_hostha_enable_ha_when_host_in_maintenance Failure 307.68 test_hostha_kvm.py
test_hostha_kvm_host_degraded Error 11.80 test_hostha_kvm.py
test_hostha_kvm_host_fencing Error 11.12 test_hostha_kvm.py
test_hostha_kvm_host_recovering Error 10.26 test_hostha_kvm.py

@DaanHoogland
Copy link
Contributor

debian smoke test have slightly better results than ubuntu24. I think we can merge , @sureshanaparti

@weizhouapache
Copy link
Member Author

@blueorangutan test debian12 kvm-debian12

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (debian12 mgmt + kvm-debian12) has been kicked to run smoke tests

@weizhouapache
Copy link
Member Author

@blueorangutan test ubuntu24 kvm-ubuntu24

@blueorangutan
Copy link

@weizhouapache a [SL] Trillian-Jenkins test job (ubuntu24 mgmt + kvm-ubuntu24) has been kicked to run smoke tests

@weizhouapache
Copy link
Member Author

debian smoke test have slightly better results than ubuntu24. I think we can merge , @sureshanaparti

@DaanHoogland @sureshanaparti
I have pushed a commit to Trillian to fix the OOBM failures with debian12 and ubuntu24.
We could wait for the test results.

@blueorangutan
Copy link

[SF] Trillian Build Failed (tid-13801)

@blueorangutan
Copy link

[SF] Trillian test result (tid-13800)
Environment: kvm-debian12 (x2), Advanced Networking with Mgmt server d12
Total time taken: 57308 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10917-t13800-kvm-debian12.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@weizhouapache
Copy link
Member Author

[SF] Trillian test result (tid-13800)
Environment: kvm-debian12 (x2), Advanced Networking with Mgmt server d12
Total time taken: 57308 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10917-t13800-kvm-debian12.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

looks perfect !
cc @sureshanaparti @DaanHoogland

@DaanHoogland DaanHoogland merged commit 30deec8 into apache:4.20 Jul 17, 2025
25 of 26 checks passed
@DaanHoogland DaanHoogland deleted the 4.20-fix-debian-uefi branch July 17, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sureshanaparti sureshanaparti sureshanaparti left review comments

@rohityadavcloud rohityadavcloud rohityadavcloud approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

Assignees
No one assigned
Labels
component:kvm
Projects
None yet
Milestone
4.20.2
Development

Successfully merging this pull request may close these issues.
6 participants
@weizhouapache @blueorangutan @DaanHoogland @sureshanaparti @rohityadavcloud @Pearl1594