-
Notifications
You must be signed in to change notification settings - Fork 1.2k
test: Update test ubuntu template for VMware to deployasis=False #10881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Update test ubuntu template for VMware to deployasis=False #10881
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #10881 +/- ##
=========================================
Coverage 16.14% 16.14%
- Complexity 13236 13239 +3
=========================================
Files 5655 5655
Lines 497310 497310
Branches 60277 60277
=========================================
+ Hits 80278 80292 +14
+ Misses 408089 408073 -16
- Partials 8943 8945 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@blueorangutan package |
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
change is being verified with downstream similar change. (still waiting for smoke test results) |
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13416 |
test_network passed
|
Out of curiosity - What changed @weizhouapache - why was this required? |
@Pearl1594 this worked
this did not work, but is fixed by this PR
maybe we should rename the 2nd test |
Ah - I missed that. Thanks @weizhouapache |
Description
This PR fixes
see #10668 (comment)
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?