Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systemvm-registration: update seeded template_store_ref sizes #10317

Open
wants to merge 1 commit into
base: 4.19
Choose a base branch
from

Conversation

rp-
Copy link
Contributor

@rp- rp- commented Feb 3, 2025

Description

Pre-seeded template storages always had there pre initialized 0 sizes and would never be updated.
This makes later problems, when the primary storage should pre-allocate the volume as it doesn't know the size
and would fail or maybe try to delay the allocation until the agent code knows the size.
This updates the sizes from the template.properties files on the validateIfSeeded check.

The issue was found while reviewing #10132

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Started a fresh KVM cluster with preseeded systemvm template from cloud-install-sys-tmplt on Linstor primary storage.

How did you try to break this feature and the system with this change?

Pre-seeded template storages always had there pre initialized 0 sizes
and would never be updated. This updates the sizes from the
template.properties files on the validateIfSeeded check.
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 15.16%. Comparing base (c1bc57b) to head (ca6c865).

Files with missing lines Patch % Lines
...om/cloud/upgrade/SystemVmTemplateRegistration.java 0.00% 24 Missing ⚠️
...ain/java/com/cloud/storage/StorageManagerImpl.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               4.19   #10317   +/-   ##
=========================================
  Coverage     15.16%   15.16%           
- Complexity    11302    11303    +1     
=========================================
  Files          5408     5408           
  Lines        473931   473950   +19     
  Branches      57844    57845    +1     
=========================================
+ Hits          71866    71869    +3     
- Misses       394034   394048   +14     
- Partials       8031     8033    +2     
Flag Coverage Δ
uitests 4.29% <ø> (ø)
unittests 15.88% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant