Minor fixes for references to Pure Storage FlashArray by sdodsley · Pull Request #10271 · apache/cloudstack

sdodsley · 2025-01-24T17:05:30Z

Description

This PR changes incorrect references to the Pure Storage FlashArray in both the actual code and in code comments.

Just wanting to make sure that the array is referenced by it correct, trademarked, name.

No functional changes.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

None

How Has This Been Tested?

N/A

How did you try to break this feature and the system with this change?

N/A

boring-cyborg · 2025-01-24T17:05:35Z

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:

In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
Be sure to read the CloudStack Coding Conventions.
Apache CloudStack is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@cloudstack.apache.org (https://cloudstack.apache.org/mailing-lists.html)
Slack: https://apachecloudstack.slack.com/

DaanHoogland · 2025-01-27T07:40:50Z

@blueorangutan package

blueorangutan · 2025-01-27T07:42:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2025-01-27T07:48:15Z

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.19%. Comparing base (98f5663) to head (d04f124).
⚠️ Report is 1176 commits behind head on 4.22.

Files with missing lines	Patch %	Lines
...e/adapter/flasharray/FlashArrayAdapterFactory.java	0.00%	1 Missing ⚠️
...ovider/FlashArrayPrimaryDatastoreProviderImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.22   #10271   +/-   ##
=========================================
  Coverage     16.19%   16.19%           
  Complexity    13051    13051           
=========================================
  Files          5645     5645           
  Lines        494567   494567           
  Branches      59955    59955           
=========================================
  Hits          80088    80088           
  Misses       405642   405642           
  Partials       8837     8837

Flag	Coverage Δ
uitests	`4.01% <ø> (ø)`
unittests	`17.04% <0.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2025-01-27T08:50:21Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12217

DaanHoogland · 2025-01-27T08:57:02Z

@blueorangutan test

blueorangutan · 2025-01-27T08:58:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-01-27T23:19:20Z

[SF] Trillian test result (tid-12192)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 49399 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10271-t12192-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_11_isolated_network_with_dynamic_routed_mode	`Error`	2.25	test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode	`Error`	2.35	test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode	`Error`	2.35	test_ipv4_routing.py

DaanHoogland · 2025-10-10T13:26:35Z

@blueorangutan package

blueorangutan · 2025-10-10T13:28:06Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-10-10T15:36:05Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 15404

blueorangutan · 2025-10-13T09:32:03Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15427

DaanHoogland · 2025-10-13T09:33:29Z

@blueorangutan test

blueorangutan · 2025-10-13T09:34:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

DaanHoogland · 2025-10-13T09:39:02Z

@sdodsley did you test this in anyway? We have no access to do a 3rd party test.

github-actions · 2026-06-18T07:08:39Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

DaanHoogland · 2026-08-31T09:21:15Z

@sdodsley @sureshanaparti I marked this for 24 as the conflicts to 22 where too big. Please have a look.

sureshanaparti · 2026-09-01T10:23:36Z

@@ -59,3 +59,6 @@ UPDATE `cloud`.`configuration`
 SET value = CONCAT_WS('\n', 'Hello {{username}}!', 'You have requested to reset your password. Please click the following link to reset your password:', '{{{resetLink}}}', 'If you did not request a password reset, please ignore this email.', '', 'Regards,', 'The CloudStack Team')
 WHERE name = 'user.password.reset.mail.template'
  AND value IN (CONCAT_WS('\n', 'Hello {{username}}!', 'You have requested to reset your password. Please click the following link to reset your password:', 'http://{{{resetLink}}}', 'If you did not request a password reset, please ignore this email.', '', 'Regards,', 'The CloudStack Team'), CONCAT_WS('\n', 'Hello {{username}}!', 'You have requested to reset your password. Please click the following link to reset your password:', '{{{domainUrl}}}{{{resetLink}}}', 'If you did not request a password reset, please ignore this email.', '', 'Regards,', 'The CloudStack Team'));
+
+-- Update storage_provider_name to FlashArray
+UPDATE cloud.storage_pool SET storage_provider_name = 'FlashArray' WHERE storage_provider_name = 'Flash Array';


@sdodsley this change would now go in the latest schema file, that upgrades to 4.24 (as the PR is target-ed for main/4.24). otherwise, rebase and re-target with 4.22 and keep this change in schema file that upgrade to 4.22.2.

4.24 is fine

Minor fixes for references to Pure Storage FlashArray

d04f124

boring-cyborg Bot added component:build component:kvm component:primary-storage component:storage component:UI labels Jan 24, 2025

DaanHoogland requested a review from andrijapanicsb January 27, 2025 07:40

sureshanaparti added this to the 4.21.0 milestone Jun 5, 2025

sureshanaparti added this to Apache CloudStack 4.21.0 Jun 5, 2025

sureshanaparti moved this to In Progress in Apache CloudStack 4.21.0 Jul 14, 2025

weizhouapache modified the milestones: 4.21.0, 4.22.0 Aug 29, 2025

sureshanaparti added this to Apache CloudStack 4.22.0 Aug 29, 2025

sureshanaparti removed this from Apache CloudStack 4.21.0 Aug 29, 2025

sureshanaparti moved this to In Progress in Apache CloudStack 4.22.0 Aug 29, 2025

Update storage provider

7b7290b

github-actions Bot added the status:has-conflicts label Jun 18, 2026

DaanHoogland added this to CloudStack Testing Aug 31, 2026

github-project-automation Bot moved this to Backlog in CloudStack Testing Aug 31, 2026

DaanHoogland changed the base branch from 4.22 to main August 31, 2026 09:18

DaanHoogland removed component:kvm component:management-server component:XenServer labels Aug 31, 2026

sureshanaparti reviewed Sep 1, 2026

View reviewed changes

Conversation

sdodsley commented Jan 24, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

boring-cyborg Bot commented Jan 24, 2025

Uh oh!

DaanHoogland commented Jan 27, 2025

Uh oh!

blueorangutan commented Jan 27, 2025

Uh oh!

codecov Bot commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Jan 27, 2025

Uh oh!

DaanHoogland commented Jan 27, 2025

Uh oh!

blueorangutan commented Jan 27, 2025

Uh oh!

blueorangutan commented Jan 27, 2025

Uh oh!

DaanHoogland commented Oct 10, 2025

Uh oh!

blueorangutan commented Oct 10, 2025

Uh oh!

blueorangutan commented Oct 10, 2025

Uh oh!

blueorangutan commented Oct 13, 2025

Uh oh!

DaanHoogland commented Oct 13, 2025

Uh oh!

blueorangutan commented Oct 13, 2025

Uh oh!

DaanHoogland commented Oct 13, 2025

Uh oh!

github-actions Bot commented Jun 18, 2026

Uh oh!

DaanHoogland commented Aug 31, 2026

Uh oh!

sureshanaparti Sep 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sdodsley Sep 1, 2026

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

codecov Bot commented Jan 27, 2025 •

edited

Loading

sureshanaparti Sep 1, 2026 •

edited

Loading