Fix NPE while checking for user data provider

[sureshanaparti]

Description

This PR fixes NPE issues while checking for user data provider.

Fixes #9847

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

Attention: Patch coverage is 4.54545% with 21 lines in your changes missing coverage. Please review.

Project coverage is 15.16%. Comparing base (0d5047b) to head (69d45d0).
Report is 4 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...oud/network/element/ConfigDriveNetworkElement.java	0.00%	11 Missing and 2 partials ⚠️
...om/cloud/network/element/VirtualRouterElement.java	0.00%	5 Missing ⚠️
.../main/java/com/cloud/network/NetworkModelImpl.java	25.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.19   #10255   +/-   ##
=========================================
  Coverage     15.16%   15.16%           
- Complexity    11300    11303    +3     
=========================================
  Files          5408     5408           
  Lines        473912   473929   +17     
  Branches      57844    57851    +7     
=========================================
+ Hits          71855    71871   +16     
+ Misses       394025   394023    -2     
- Partials       8032     8035    +3     

Flag	Coverage Δ
uitests	4.29% <ø> (ø)
unittests	15.88% <4.54%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[DaanHoogland]

clgtm

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12189

[sureshanaparti]

@blueorangutan test

[blueorangutan]

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-12181)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 48629 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10255-t12181-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[Pearl1594]

Overall LGTM, just one comment.

[DaanHoogland]

@sureshanaparti , the issue speaks of deletion of a VR in an edge zone. Are there special requirements for testing this fix concerning making an edge zone?
tnx

[sureshanaparti]

@sureshanaparti , the issue speaks of deletion of a VR in an edge zone. Are there special requirements for testing this fix concerning making an edge zone? tnx

@DaanHoogland create edge zone and don't register direct download systemvm template. Create shared network and try to deploy VM (The network creation fails as there is no direct download systemvm template to create the VR, at this point - destroy the VR of the shared network).

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12307

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[Pearl1594]

Thanks @sureshanaparti. LGTM. Code has been made more defensive to prevent NPEs.

[blueorangutan]

[SF] Trillian test result (tid-12279)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 50199 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10255-t12279-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_12_start_vm_multiple_volumes_allocated	Error	15.11	test_vm_life_cycle.py