server: apply network ACL even if there is no network ACLs in the ACL list (#9374)

[weizhouapache]

Description

This PR re-applies #9374

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[weizhouapache]

@blueorangutan package

[blueorangutan]

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.13%. Comparing base (96b757c) to head (a1daf60).

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #10241   +/-   ##
=========================================
  Coverage     16.13%   16.13%           
  Complexity    12972    12972           
=========================================
  Files          5639     5639           
  Lines        494297   494294    -3     
  Branches      59908    59908           
=========================================
+ Hits          79773    79775    +2     
+ Misses       405698   405694    -4     
+ Partials       8826     8825    -1     

Flag	Coverage Δ
uitests	4.02% <ø> (ø)
unittests	16.98% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DaanHoogland]

looks good, probably a merge error

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12172

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-12171)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 40614 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10241-t12171-kvm-ol8.zip
Smoke tests completed. 131 look OK, 1 have errors, 9 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_11_isolated_network_with_dynamic_routed_mode	Error	2.28	test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode	Error	3.38	test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode	Error	3.38	test_ipv4_routing.py
all_test_volumes	Skipped	---	test_volumes.py
all_test_vpc_ipv6	Skipped	---	test_vpc_ipv6.py
all_test_vpc_redundant	Skipped	---	test_vpc_redundant.py
all_test_vpc_router_nics	Skipped	---	test_vpc_router_nics.py
all_test_vpc_vpn	Skipped	---	test_vpc_vpn.py
all_test_webhook_delivery	Skipped	---	test_webhook_delivery.py
all_test_webhook_lifecycle	Skipped	---	test_webhook_lifecycle.py
all_test_host_maintenance	Skipped	---	test_host_maintenance.py
all_test_hostha_kvm	Skipped	---	test_hostha_kvm.py

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian Build Failed (tid-12173)

[weizhouapache]

@blueorangutan test

[blueorangutan]

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-12211)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 54129 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10241-t12211-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_11_isolated_network_with_dynamic_routed_mode	Error	2.34	test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode	Error	3.46	test_ipv4_routing.py
test_12_vpc_and_tier_with_dynamic_routed_mode	Error	3.47	test_ipv4_routing.py