-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Vmware fix test errors #10162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Vmware fix test errors #10162
Conversation
@blueorangutan package |
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13618 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10162 +/- ##
=============================================
- Coverage 15.80% 0 -15.81%
=============================================
Files 5627 0 -5627
Lines 492363 0 -492363
Branches 59696 0 -59696
=============================================
- Hits 77828 0 -77828
+ Misses 406012 0 -406012
+ Partials 8523 0 -8523
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13669 |
@@ -39,17 +39,20 @@ public class ProcessTest { | |||
|
|||
@Test | |||
public void testProcessRunner() { | |||
ProcessResult result = RUNNER.executeCommands(Arrays.asList("sleep", "0")); | |||
// Replace "sleep" with the cross-platform "timeout" command | |||
ProcessResult result = RUNNER.executeCommands(Arrays.asList("timeout", "/t", "1")); | |||
Assert.assertEquals(result.getReturnCode(), 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iishitahere , this test fails at this assert.
This PR implements enhancements related to traffic shaping and VMware network configurations:
NetUtilsTest: Improved handling of default NIC IPs to ensure compatibility with both IPv4 and IPv6 formats for traffic shaping configurations.
ScriptTest: Updated command execution handling to ensure better compatibility with VMware's network setup, improving timeout management and process error handling.
ProcessTest: Addressed potential race conditions in process execution, enhancing stability during network traffic shaping tests on VMware environments.