Skip to content

Modify State Changing Requests to Utilize POST Request #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 19, 2025
Merged

Modify State Changing Requests to Utilize POST Request #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5d1507e
State changing request using POST request
Apr 15, 2025
58c02d1
Reverting changes to newRequest
Apr 16, 2025
bfde559
Reverting some commands back to GET requests
Apr 23, 2025
496e0eb
Merge branch 'main' of github.com:apache/cloudstack-go into modify_po…
May 31, 2025
1b92154
added signatureversion and expires params to api request
sureshanaparti Jun 2, 2025
9164e3c
Updated generate.go with get api call check
sureshanaparti Jun 16, 2025
2584bd3
Updated required params for create VPC, and generate changes
sureshanaparti Jun 16, 2025
5ba605d
review change
sureshanaparti Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cloudstack/ASNumberRangeService.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ func (s *ASNumberRangeService) NewCreateASNRangeParams(endasn int64, startasn in

// Creates a range of Autonomous Systems for BGP Dynamic Routing
func (s *ASNumberRangeService) CreateASNRange(p *CreateASNRangeParams) (*CreateASNRangeResponse, error) {
resp, err := s.cs.newRequest("createASNRange", p.toURLValues())
resp, err := s.cs.newPostRequest("createASNRange", p.toURLValues())
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -203,7 +203,7 @@ func (s *ASNumberRangeService) NewDeleteASNRangeParams(id string) *DeleteASNRang

// deletes a range of Autonomous Systems for BGP Dynamic Routing
func (s *ASNumberRangeService) DeleteASNRange(p *DeleteASNRangeParams) (*DeleteASNRangeResponse, error) {
resp, err := s.cs.newRequest("deleteASNRange", p.toURLValues())
resp, err := s.cs.newPostRequest("deleteASNRange", p.toURLValues())
if err != nil {
return nil, err
}
Expand Down
2 changes: 1 addition & 1 deletion cloudstack/ASNumberService.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ func (s *ASNumberService) NewReleaseASNumberParams(asnumber int64, zoneid string

// Releases an AS Number back to the pool
func (s *ASNumberService) ReleaseASNumber(p *ReleaseASNumberParams) (*ReleaseASNumberResponse, error) {
resp, err := s.cs.newRequest("releaseASNumber", p.toURLValues())
resp, err := s.cs.newPostRequest("releaseASNumber", p.toURLValues())
if err != nil {
return nil, err
}
Expand Down
16 changes: 8 additions & 8 deletions cloudstack/AccountService.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ func (s *AccountService) NewCreateAccountParams(email string, firstname string,

// Creates an account
func (s *AccountService) CreateAccount(p *CreateAccountParams) (*CreateAccountResponse, error) {
resp, err := s.cs.newRequest("createAccount", p.toURLValues())
resp, err := s.cs.newPostRequest("createAccount", p.toURLValues())
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -579,7 +579,7 @@ func (s *AccountService) NewDeleteAccountParams(id string) *DeleteAccountParams

// Deletes a account, and all users associated with this account
func (s *AccountService) DeleteAccount(p *DeleteAccountParams) (*DeleteAccountResponse, error) {
resp, err := s.cs.newRequest("deleteAccount", p.toURLValues())
resp, err := s.cs.newPostRequest("deleteAccount", p.toURLValues())
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -734,7 +734,7 @@ func (s *AccountService) NewDisableAccountParams(lock bool) *DisableAccountParam

// Disables an account
func (s *AccountService) DisableAccount(p *DisableAccountParams) (*DisableAccountResponse, error) {
resp, err := s.cs.newRequest("disableAccount", p.toURLValues())
resp, err := s.cs.newPostRequest("disableAccount", p.toURLValues())
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -953,7 +953,7 @@ func (s *AccountService) NewEnableAccountParams() *EnableAccountParams {

// Enables an account
func (s *AccountService) EnableAccount(p *EnableAccountParams) (*EnableAccountResponse, error) {
resp, err := s.cs.newRequest("enableAccount", p.toURLValues())
resp, err := s.cs.newPostRequest("enableAccount", p.toURLValues())
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -1317,7 +1317,7 @@ func (s *AccountService) NewLinkAccountToLdapParams(account string, domainid str

// link a cloudstack account to a group or OU in ldap
func (s *AccountService) LinkAccountToLdap(p *LinkAccountToLdapParams) (*LinkAccountToLdapResponse, error) {
resp, err := s.cs.newRequest("linkAccountToLdap", p.toURLValues())
resp, err := s.cs.newPostRequest("linkAccountToLdap", p.toURLValues())
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -2310,7 +2310,7 @@ func (s *AccountService) NewLockAccountParams(account string, domainid string) *

// This deprecated function used to locks an account. Look for the API DisableAccount instead
func (s *AccountService) LockAccount(p *LockAccountParams) (*LockAccountResponse, error) {
resp, err := s.cs.newRequest("lockAccount", p.toURLValues())
resp, err := s.cs.newPostRequest("lockAccount", p.toURLValues())
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -2512,7 +2512,7 @@ func (s *AccountService) NewMarkDefaultZoneForAccountParams(account string, doma

// Marks a default zone for this account
func (s *AccountService) MarkDefaultZoneForAccount(p *MarkDefaultZoneForAccountParams) (*MarkDefaultZoneForAccountResponse, error) {
resp, err := s.cs.newRequest("markDefaultZoneForAccount", p.toURLValues())
resp, err := s.cs.newPostRequest("markDefaultZoneForAccount", p.toURLValues())
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -2830,7 +2830,7 @@ func (s *AccountService) NewUpdateAccountParams() *UpdateAccountParams {

// Updates account information for the authenticated user
func (s *AccountService) UpdateAccount(p *UpdateAccountParams) (*UpdateAccountResponse, error) {
resp, err := s.cs.newRequest("updateAccount", p.toURLValues())
resp, err := s.cs.newPostRequest("updateAccount", p.toURLValues())
if err != nil {
return nil, err
}
Expand Down
14 changes: 7 additions & 7 deletions cloudstack/AddressService.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ func (s *AddressService) NewAcquirePodIpAddressParams(zoneid string) *AcquirePod

// Allocates IP addresses in respective Pod of a Zone
func (s *AddressService) AcquirePodIpAddress(p *AcquirePodIpAddressParams) (*AcquirePodIpAddressResponse, error) {
resp, err := s.cs.newRequest("acquirePodIpAddress", p.toURLValues())
resp, err := s.cs.newPostRequest("acquirePodIpAddress", p.toURLValues())
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -408,7 +408,7 @@ func (s *AddressService) NewAssociateIpAddressParams() *AssociateIpAddressParams

// Acquires and associates a public IP to an account.
func (s *AddressService) AssociateIpAddress(p *AssociateIpAddressParams) (*AssociateIpAddressResponse, error) {
resp, err := s.cs.newRequest("associateIpAddress", p.toURLValues())
resp, err := s.cs.newPostRequest("associateIpAddress", p.toURLValues())
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -554,7 +554,7 @@ func (s *AddressService) NewDisassociateIpAddressParams(id string) *Disassociate

// Disassociates an IP address from the account.
func (s *AddressService) DisassociateIpAddress(p *DisassociateIpAddressParams) (*DisassociateIpAddressResponse, error) {
resp, err := s.cs.newRequest("disassociateIpAddress", p.toURLValues())
resp, err := s.cs.newPostRequest("disassociateIpAddress", p.toURLValues())
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -1440,7 +1440,7 @@ func (s *AddressService) NewUpdateIpAddressParams(id string) *UpdateIpAddressPar

// Updates an IP address
func (s *AddressService) UpdateIpAddress(p *UpdateIpAddressParams) (*UpdateIpAddressResponse, error) {
resp, err := s.cs.newRequest("updateIpAddress", p.toURLValues())
resp, err := s.cs.newPostRequest("updateIpAddress", p.toURLValues())
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -1562,7 +1562,7 @@ func (s *AddressService) NewReleaseIpAddressParams(id string) *ReleaseIpAddressP

// Releases an IP address from the account.
func (s *AddressService) ReleaseIpAddress(p *ReleaseIpAddressParams) (*ReleaseIpAddressResponse, error) {
resp, err := s.cs.newRequest("releaseIpAddress", p.toURLValues())
resp, err := s.cs.newPostRequest("releaseIpAddress", p.toURLValues())
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -1657,7 +1657,7 @@ func (s *AddressService) NewReleasePodIpAddressParams(id int64) *ReleasePodIpAdd

// Releases a Pod IP back to the Pod
func (s *AddressService) ReleasePodIpAddress(p *ReleasePodIpAddressParams) (*ReleasePodIpAddressResponse, error) {
resp, err := s.cs.newRequest("releasePodIpAddress", p.toURLValues())
resp, err := s.cs.newPostRequest("releasePodIpAddress", p.toURLValues())
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -1848,7 +1848,7 @@ func (s *AddressService) NewReserveIpAddressParams(id string) *ReserveIpAddressP

// Reserve a public IP to an account.
func (s *AddressService) ReserveIpAddress(p *ReserveIpAddressParams) (*ReserveIpAddressResponse, error) {
resp, err := s.cs.newRequest("reserveIpAddress", p.toURLValues())
resp, err := s.cs.newPostRequest("reserveIpAddress", p.toURLValues())
if err != nil {
return nil, err
}
Expand Down
6 changes: 3 additions & 3 deletions cloudstack/AffinityGroupService.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ func (s *AffinityGroupService) NewCreateAffinityGroupParams(name string, affinit

// Creates an affinity/anti-affinity group
func (s *AffinityGroupService) CreateAffinityGroup(p *CreateAffinityGroupParams) (*CreateAffinityGroupResponse, error) {
resp, err := s.cs.newRequest("createAffinityGroup", p.toURLValues())
resp, err := s.cs.newPostRequest("createAffinityGroup", p.toURLValues())
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -403,7 +403,7 @@ func (s *AffinityGroupService) NewDeleteAffinityGroupParams() *DeleteAffinityGro

// Deletes affinity group
func (s *AffinityGroupService) DeleteAffinityGroup(p *DeleteAffinityGroupParams) (*DeleteAffinityGroupResponse, error) {
resp, err := s.cs.newRequest("deleteAffinityGroup", p.toURLValues())
resp, err := s.cs.newPostRequest("deleteAffinityGroup", p.toURLValues())
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -1095,7 +1095,7 @@ func (s *AffinityGroupService) NewUpdateVMAffinityGroupParams(id string) *Update

// Updates the affinity/anti-affinity group associations of a virtual machine. The VM has to be stopped and restarted for the new properties to take effect.
func (s *AffinityGroupService) UpdateVMAffinityGroup(p *UpdateVMAffinityGroupParams) (*UpdateVMAffinityGroupResponse, error) {
resp, err := s.cs.newRequest("updateVMAffinityGroup", p.toURLValues())
resp, err := s.cs.newPostRequest("updateVMAffinityGroup", p.toURLValues())
if err != nil {
return nil, err
}
Expand Down
6 changes: 3 additions & 3 deletions cloudstack/AlertService.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ func (s *AlertService) NewArchiveAlertsParams() *ArchiveAlertsParams {

// Archive one or more alerts.
func (s *AlertService) ArchiveAlerts(p *ArchiveAlertsParams) (*ArchiveAlertsResponse, error) {
resp, err := s.cs.newRequest("archiveAlerts", p.toURLValues())
resp, err := s.cs.newPostRequest("archiveAlerts", p.toURLValues())
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -328,7 +328,7 @@ func (s *AlertService) NewDeleteAlertsParams() *DeleteAlertsParams {

// Delete one or more alerts.
func (s *AlertService) DeleteAlerts(p *DeleteAlertsParams) (*DeleteAlertsResponse, error) {
resp, err := s.cs.newRequest("deleteAlerts", p.toURLValues())
resp, err := s.cs.newPostRequest("deleteAlerts", p.toURLValues())
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -521,7 +521,7 @@ func (s *AlertService) NewGenerateAlertParams(description string, name string, a

// Generates an alert
func (s *AlertService) GenerateAlert(p *GenerateAlertParams) (*GenerateAlertResponse, error) {
resp, err := s.cs.newRequest("generateAlert", p.toURLValues())
resp, err := s.cs.newPostRequest("generateAlert", p.toURLValues())
if err != nil {
return nil, err
}
Expand Down
6 changes: 3 additions & 3 deletions cloudstack/AnnotationService.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ func (s *AnnotationService) NewAddAnnotationParams() *AddAnnotationParams {

// add an annotation.
func (s *AnnotationService) AddAnnotation(p *AddAnnotationParams) (*AddAnnotationResponse, error) {
resp, err := s.cs.newRequest("addAnnotation", p.toURLValues())
resp, err := s.cs.newPostRequest("addAnnotation", p.toURLValues())
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -519,7 +519,7 @@ func (s *AnnotationService) NewRemoveAnnotationParams(id string) *RemoveAnnotati

// remove an annotation.
func (s *AnnotationService) RemoveAnnotation(p *RemoveAnnotationParams) (*RemoveAnnotationResponse, error) {
resp, err := s.cs.newRequest("removeAnnotation", p.toURLValues())
resp, err := s.cs.newPostRequest("removeAnnotation", p.toURLValues())
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -624,7 +624,7 @@ func (s *AnnotationService) NewUpdateAnnotationVisibilityParams(adminsonly bool,

// update an annotation visibility.
func (s *AnnotationService) UpdateAnnotationVisibility(p *UpdateAnnotationVisibilityParams) (*UpdateAnnotationVisibilityResponse, error) {
resp, err := s.cs.newRequest("updateAnnotationVisibility", p.toURLValues())
resp, err := s.cs.newPostRequest("updateAnnotationVisibility", p.toURLValues())
if err != nil {
return nil, err
}
Expand Down
4 changes: 2 additions & 2 deletions cloudstack/AuthenticationService.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ func (s *AuthenticationService) NewLogoutParams() *LogoutParams {

// Logs out the user
func (s *AuthenticationService) Logout(p *LogoutParams) (*LogoutResponse, error) {
resp, err := s.cs.newRequest("logout", p.toURLValues())
resp, err := s.cs.newPostRequest("logout", p.toURLValues())
if err != nil {
return nil, err
}
Expand Down Expand Up @@ -375,7 +375,7 @@ func (s *AuthenticationService) NewOauthloginParams(email string, provider strin

// Logs a user into the CloudStack after successful verification of OAuth secret code from the particular provider.A successful login attempt will generate a JSESSIONID cookie value that can be passed in subsequent Query command calls until the "logout" command has been issued or the session has expired.
func (s *AuthenticationService) Oauthlogin(p *OauthloginParams) (*OauthloginResponse, error) {
resp, err := s.cs.newRequest("oauthlogin", p.toURLValues())
resp, err := s.cs.newPostRequest("oauthlogin", p.toURLValues())
if err != nil {
return nil, err
}
Expand Down
Loading
Loading