REL_2_STABLE: Fix binary swap test failure on PG version bump#1634
Merged
x4m merged 3 commits intoapache:REL_2_STABLEfrom Mar 23, 2026
Merged
REL_2_STABLE: Fix binary swap test failure on PG version bump#1634x4m merged 3 commits intoapache:REL_2_STABLEfrom
x4m merged 3 commits intoapache:REL_2_STABLEfrom
Conversation
The binary swap test compares pg_dump outputs between baseline and current builds using a plain diff. When upgrading the PG kernel minor version (e.g. 14.4 to 14.5), the "-- Dumped from database version" comment line in pg_dump output differs between the two builds, causing a false test failure. Add the `-I` flag with a regex pattern to the diff command in diff_dumps.sql so that comment-only version lines are ignored during comparison. This preserves detection of any real catalog, schema, or data incompatibilities while allowing PG minor version bumps without breaking the binary swap CI check.
tuhaihe
force-pushed
the
fix-abi-check-REL2
branch
from
e293e50 to
c1014a3
Compare
The binary swap workflow previously only reported catalog version information when comparing baseline and current builds. This made it difficult to see at a glance which PostgreSQL kernel minor version each build was based on. Extract the underlying PostgreSQL kernel version from both baseline and current installs via `pg_config --version`. Display the comparison in the terminal log alongside the existing catalog version check, and include it in the GitHub Step Summary report for better visibility during PG minor version upgrades (e.g. 14.4 to 14.5).
Member
Author
|
As discussed in PR #1621, we are upgrading the Postgres minor kernel version to align with the upstream release, providing developers and users with better visibility into the base kernel changes. |
Smyatkin-Maxim
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions