[CELEBORN-1909] Support pre-run static code blocks of TransportMessages to improve performance of protobuf serialization #3149
+75
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es to improve performance of protobuf serialization
|
@SteNicholas Thanks, this PR looks very interesting. Is there any performance data to share with us? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support pre-run static code blocks of TransportMessages to improve performance of protobuf serialization.
Why are the changes needed?
The protobuf message protocol defines many map type fields, which makes it time-consuming to build these message instances. This is because TransportMessages contains static code blocks to initialize a large number of
Descriptors andFieldAccessorTables, where the instantiation ofFieldAccessorTableincludes reflection. The test result proves that the static code blocks execute in about 70 milliseconds.Therefore, it's better to pre-run static code blocks of
TransportMessagesto improve performance of protobuf serialization. Meanwhile, it's recommended to use repeated instead of map type field for rpc messages.Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI.