[CELEBORN-1902] Read client throws PartitionConnectionException #3147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Austinfjq, could you explain why this throws |
I think for this following error,
I might be missing something. Can downstream task be retried? I assume it hasn't started. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
org.apache.flink.runtime.io.network.partition.consumer.PartitionConnectionExceptionis thrown when RemoteBufferStreamReader finds that the current exception is about connection failure.Why are the changes needed?
If
org.apache.flink.runtime.io.network.partition.consumer.PartitionConnectionExceptionis correctly thrown to reflect connection failure, then Flink can be aware of the lost Celeborn server side nodes and be able to re-compute affected data. Otherwise, endless retries could cause Flink job failure.This PR is to deal with exceptions like:
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Tested in a Flink batch job with Celeborn.