[CELEBORN-1893] Support jemalloc.so.2 #3131
Conversation
SteNicholas
changed the title
| @@ -84,16 +84,19 @@ fi | |||
| maybe_enable_jemalloc() { | |||
| if [ "${CELEBORN_PREFER_JEMALLOC:-false}" == "true" ]; then | |||
| JEMALLOC_PATH="${CELEBORN_JEMALLOC_PATH:-/usr/lib/$(uname -m)-linux-gnu/libjemalloc.so}" | |||
| JEMALLOC2_PATH="/usr/lib/$(uname -m)-linux-gnu/libjemalloc.so.2" | |||
There was a problem hiding this comment.
| JEMALLOC2_PATH="/usr/lib/$(uname -m)-linux-gnu/libjemalloc.so.2" | |
| JEMALLOC2_PATH="${CELEBORN_JEMALLOC_PATH:-/usr/lib/$(uname -m)-linux-gnu/libjemalloc.so.2}" |
|
Usually, libjemalloc.so could be linked to libjemalloc.so.2 (correct me if I'm wrong). I'm a bit concerned that there may be other versions of jemalloc in the future. |
|
The original intention of auto searching |
|
We use it internally, if it's not standardized I am happy to close this PR and explicitly set Another fix could be to find any file named libjemalloc.so* and try to use that, what do you think? |
Perhaps we can add another fallback, so that when both the JEMALLOC_PATH and JEMALLOC_FALLBACK do not exist, it can perform an auto search cc @pan3793 |
What changes were proposed in this pull request?
Support
libjemalloc.so.2by default when CELEBORN_PREFER_JEMALLOC is set to trueWhy are the changes needed?
Currently only
libjemalloc.sois supported. We can manually set CELEBORN_JEMALLOC_PATH to the.so.2path but would be nice to be able to support this by default. Happy to close this if community prefers just setting CELEBORN_JEMALLOC_PATH manually.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually tested that the .so.2 path gets set when the .so.2 path doesn't exist and running in prod.