[CELEBORN-1856]Support stage-rerun when read partition by chunkOffsets when enable optimize skew partition read #3118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cluster test is doing |
wangshengjie123
changed the title
wangshengjie123
changed the title
wangshengjie123
changed the title
|
Thank you for your efforts, @wangshengjie123 , is there any update? |
wangshengjie123
changed the title
Updated, fix some data consistency issues. I will rebase the code later PTAL, thanks @RexXiong |
…ts when enable optimize skew partition read
…nstream shuffle, should get a new shuffle id
wangshengjie123
force-pushed
the
support-stage-rerun
branch
from
88fa883 to
264265c
Compare
RexXiong
reviewed
Mar 6, 2025
There was a problem hiding this comment.
We also need to check (!stage.isIndeterminate && task.stageAttemptId < stage.latestInfo.attemptNumber()) when the task succeeds, just as we would for an indeterminate stage. Skew Partition read task should ignore partition complete event when task.stageAttemptId < stage.latestInfo.attemptNumber()
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala
Outdated
Show resolved
Hide resolved
client-spark/spark-3/src/main/java/org/apache/spark/shuffle/celeborn/SparkUtils.java
Outdated
Show resolved
Hide resolved
assets/spark-patch/Celeborn-Optimize-Skew-Partitions-spark3_2.patch
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support stage-rerun when read partition by chunkOffsets when enable optimize skew partition read
Why are the changes needed?
In CELEBORN-1319, we have already implemented the skew partition read optimization based on chunk offsets, but we don't support skew partition shuffle retry, so we need support the stage rerun.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Cluster test