[CELEBORN-1844][CIP-8] introduce tier writer proxy and simplify partition data writer #3085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FMX
changed the title
FMX
changed the title
FMX
force-pushed
the
1844
branch
4 times, most recently
from
b2dbe4b to
1345ffb
Compare
FMX
force-pushed
the
1844
branch
4 times, most recently
from
0024fb5 to
15e0a54
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3085 +/- ##
==========================================
+ Coverage 32.62% 32.69% +0.07%
==========================================
Files 336 338 +2
Lines 20083 20273 +190
Branches 1798 1812 +14
==========================================
+ Hits 6551 6626 +75
- Misses 13165 13278 +113
- Partials 367 369 +2 ☔ View full report in Codecov by Sentry. |
RexXiong
reviewed
Feb 21, 2025
worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/PartitionDataWriter.java
Outdated
Show resolved
Hide resolved
worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/PartitionDataWriter.java
Outdated
Show resolved
Hide resolved
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/TierWriterProxy.scala
Show resolved
Hide resolved
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Controller.scala
Outdated
Show resolved
Hide resolved
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/PushDataHandler.scala
Show resolved
Hide resolved
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/TierWriter.scala
Show resolved
Hide resolved
RexXiong
reviewed
Feb 28, 2025
worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/PartitionDataWriter.java
Show resolved
Hide resolved
worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/PartitionDataWriter.java
Outdated
Show resolved
Hide resolved
worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/PartitionDataWriter.java
Show resolved
Hide resolved
worker/src/main/java/org/apache/celeborn/service/deploy/worker/storage/PartitionDataWriter.java
Outdated
Show resolved
Hide resolved
worker/src/main/scala/org/apache/celeborn/service/deploy/worker/storage/TierWriterProxy.scala
Outdated
Show resolved
Hide resolved
FMX
force-pushed
the
1844
branch
3 times, most recently
from
842fbb4 to
3a86168
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Most of the contents of this PR is the changes for UT, and it's derived from another PR #3083.
Why are the changes needed?
Introduce tier writer proxy and simplify the partition data writer.
Does this PR introduce any user-facing change?
NO.
How was this patch tested?
GA and manual tests.
I have verified data correctness on a cluster using TPC-DS tests.