Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test
org.apache.cayenne.util.WeakValueMapTest.testConcurrentModification
will fail under NonDex which detects flakiness under non-deterministic environment.To reproduce:
Issue
The test code follows the logic below:
While WeakValueMap uses HashMap internally, it is not guaranteed for
map.entrySet
to iterate over the entries under some orders.The code is expected to thrown
ConcurrentModificationException
during execution. Under some edge cases, eg:key_2
is traversed and removed last, the test will fail to throw and cause an issue.