fix: replace non deterministic order data structure #470
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
org.apache.cayenne.log.CompactSlf4jJdbcEventLoggerTest.compactBindings
will fail under NonDex tool that detect flakiness under non-deterministic order.In function
CompactSlf4jJdbcEventLogger .collectBindings
, the function is declared with the usage of HashMap.Whereas the test relies on the result of the HashMap to determine the output, whereas toString should not be able to guarantee the order of insertion.
I proposed to use LinkedHashMap to keep the hash property while maintaining some kind of ordering.