perf(util): replace global RWMutex with sync.Map in reCache to eliminate mutex contention (fix #1690) - #1750
Open
Jaymr1031-Z wants to merge 1 commit into
Open
Conversation
… to eliminate contention (fix apache#1690)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1690
Problem
In util/builtin_operators.go, mustCompileOrGet() guarded regex cache access with a global sync.RWMutex (
eCacheMu). Under high-throughput concurrent policy evaluation across multiple goroutines, the mutex lock contention created unnecessary bottlenecks.
Solution
eCache (map[string]*regexp.Regexp) and
eCacheMu (sync.RWMutex) with a thread-safe, lock-free sync.Map.
eCache.Load and
eCache.LoadOrStore inside mustCompileOrGet for lock-free read-heavy access.