-
Notifications
You must be signed in to change notification settings - Fork 5.1k
feat(api): add exchange property and variable helpers #21095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.camel; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.HashMap; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| /** | ||
| * ExchangeSupport is an internal class used to support Exchange default methods. | ||
| */ | ||
| public class ExchangeSupport { | ||
|
|
||
| protected static <T> List<T> getObjectAsList(Object value, Class<T> elementType) { | ||
| if (value == null || !(value instanceof Iterable<?> iterable)) { | ||
| return null; | ||
| } | ||
|
|
||
| List<T> result = new ArrayList<>(); | ||
| for (Object element : iterable) { | ||
| if (!elementType.isInstance(element)) { | ||
| return null; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we return null, skip the item or throw the exception? I had followed the original API, for which any error on the cast of the property would return null. But maybe we can change it in these implementations.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what about skipping and LOG.warn the skipped element? |
||
| } | ||
| result.add(elementType.cast(element)); | ||
| } | ||
|
|
||
| return List.copyOf(result); | ||
| } | ||
|
|
||
| protected static <K, V> Map<K, V> getObjectAsMap(Object value, Class<K> keyType, Class<V> valueType) { | ||
| if (value == null || !(value instanceof Map<?, ?> rawMap)) { | ||
| return null; | ||
| } | ||
|
|
||
| Map<K, V> result = new HashMap<>(); | ||
| for (Map.Entry<?, ?> entry : rawMap.entrySet()) { | ||
| Object rawKey = entry.getKey(); | ||
| Object rawValue = entry.getValue(); | ||
|
|
||
| if (rawKey == null || !keyType.isInstance(rawKey)) { | ||
| return null; | ||
| } | ||
|
|
||
| if (!valueType.isInstance(rawValue)) { | ||
| return null; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same question about the casting posed above. |
||
| } | ||
|
|
||
| try { | ||
| result.put( | ||
| keyType.cast(rawKey), | ||
| valueType.cast(rawValue)); | ||
| } catch (ClassCastException cce) { | ||
| return null; | ||
| } | ||
| } | ||
|
|
||
| return Map.copyOf(result); | ||
| } | ||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that this
isIstancecheck within a loop is very likely to hit the JVM secondary super issue which triggers a false sharing problem and affects pretty much everything older than Java 22.