When the thread has been interrupted, there is no need for waitBackOffTime #3961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangc0276
approved these changes
Jun 13, 2023
zymap
requested changes
Jun 19, 2023
| if (Thread.currentThread().isInterrupted()) { | ||
| LOG.error("Interrupted while replicating fragments"); | ||
| shutdown(); | ||
| return; | ||
| } | ||
| waitBackOffTime(rwRereplicateBackoffMs); |
There was a problem hiding this comment.
We already handled the InterruptedException at line 251. It looks like there want to check if the thread is interrupted after waiting the time. In the waitBackOffTime, it may interrupt the current thread.
|
@wenbingshen Close this PR. If you have more updates, please reopen it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When the thread has been interrupted, there is no need for waitBackOffTime, we can directly shutdown ReplicationWorker.