Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIGTOP-3564. Fix build failure of Flink on Cent OS 7 ppc64le. #793

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

iwasakims
Copy link
Member

@iwasakims iwasakims commented Jun 28, 2021

https://issues.apache.org/jira/browse/BIGTOP-3564

Build fails due to error related to node.js.

Running 'npm ci --cache-max=0 --no-save' in /bigtop/build/flink/rpm/BUILD/flink-1.11.3/flink-runtime-web/web-dashboard
/bigtop/build/flink/rpm/BUILD/flink-1.11.3/flink-runtime-web/web-dashboard/node/node: /lib64/libstdc++.so.6: version `GLIBCXX_3.4.20' not found (required by /bigtop/build/flink/rpm/BUILD/flink-1.11.3/flink-runtime-web/web-dashboard/node/node)

eirslett/frontend-maven-plugin#852 reported that using v.12 node.js fixed similar issue.

I did not test this on ppc64le.

@iwasakims
Copy link
Member Author

There was a issue related to graceful-fs on upgrading node.js from v.10 to v.12 for Hadoop in apache/hadoop#3128. Flink might need similar fix.

$ grep -r graceful-fs flink-runtime-web
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.11",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:    "node_modules/graceful-fs": {
flink-runtime-web/web-dashboard/package-lock.json:      "resolved": "https://registry.npmjs.org/graceful-fs/-/graceful-fs-4.1.15.tgz",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.6"
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.15",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.15",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.11",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.15",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:            "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.11",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:    "graceful-fs": {
flink-runtime-web/web-dashboard/package-lock.json:      "resolved": "https://registry.npmjs.org/graceful-fs/-/graceful-fs-4.1.15.tgz",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.6"
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:            "graceful-fs": "^4.1.15",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:            "graceful-fs": "^4.1.15",
flink-runtime-web/web-dashboard/package-lock.json:            "graceful-fs": "^4.1.2",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.11",
flink-runtime-web/web-dashboard/package-lock.json:            "graceful-fs": "^4.1.15",
flink-runtime-web/web-dashboard/package-lock.json:        "graceful-fs": "^4.1.2",

@iwasakims
Copy link
Member Author

Even the current trunk of Flink uses node.js 10.9.0 (same as of Flink 1.11.3).

@iwasakims
Copy link
Member Author

Just dropping Web UI support on ppc64le could be an option.

if [ $HOSTTYPE = "powerpc64le" ] ; then
  FLINK_BUILD_OPTS="-Pskip-webui-build ${FLINK_BUILD_OPTS}"
fi

@sekikn
Copy link
Contributor

sekikn commented Jun 28, 2021

@iwasakims I tried the current PR (0013b19) on ppc64le and it succeeded as far as building a package.

jenkins@bigtop1slave:~/bigtop$ docker run -v $PWD:/bigtop -it bigtop/slaves:trunk-centos-7-ppc64le bash
[root@5950c2bf9f66 /]# cd bigtop
[root@5950c2bf9f66 bigtop]# ./gradlew flink-pkg



[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:03 min
[INFO] Finished at: 2021-06-28T14:03:54Z
[INFO] ------------------------------------------------------------------------

...

> Task :flink-pkg

BUILD SUCCESSFUL in 58m 44s
57 actionable tasks: 57 executed

But I'm not sure about the graceful-fs matter. Is that OK if the build succeeded, or do we have to set up Flink's web UI so as to make sure if it works with the old version of graceful-fs?

@iwasakims
Copy link
Member Author

Thanks, @sekikn. I think we should commit this and move the release forward. We can wait feedback and address additional issues in follow-up JIRA. There might be no problem since graceful-fs 3 is not used at least.

@sekikn
Copy link
Contributor

sekikn commented Jun 29, 2021

OK, I'm going to merge this with my +1. Thanks @iwasakims!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants